Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter notebook for visualization #370

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Jupyter notebook for visualization #370

merged 3 commits into from
Oct 14, 2023

Conversation

vhavlena
Copy link
Collaborator

Notebook showing possibilities of automata visualisation in mata.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1494bd4) 71.80% compared to head (4eee120) 71.82%.
Report is 7 commits behind head on devel.

❗ Current head 4eee120 differs from pull request most recent head c721e11. Consider uploading reports for the commit c721e11 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #370      +/-   ##
==========================================
+ Coverage   71.80%   71.82%   +0.01%     
==========================================
  Files          30       30              
  Lines        3643     3642       -1     
  Branches      836      834       -2     
==========================================
  Hits         2616     2616              
  Misses        735      735              
+ Partials      292      291       -1     
Files Coverage Δ
include/mata/utils/ord-vector.hh 68.66% <100.00%> (+0.42%) ⬆️
src/nfa/inclusion.cc 90.82% <100.00%> (+0.58%) ⬆️
src/nfa/delta.cc 82.52% <81.81%> (+0.15%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Adda0
Copy link
Collaborator

Adda0 commented Oct 11, 2023

This was badly needed. I will review the PR later today as soon as I can. From the quick glance, the PR seems nice.

@vhavlena
Copy link
Collaborator Author

@kilohsakul maybe wanted to include such a notebook to the paper. Lukas, please look at it.

Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should add one of the examples to the paper.

@kilohsakul
Copy link
Collaborator

Krasne! Jeste by to fakt mohlo kreslit horizontalne.

@vhavlena
Copy link
Collaborator Author

I think it is ready for merge.

Copy link
Member

@tfiedor tfiedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine, probably remove those commented lines though, if they are not used anywhere.

@Adda0
Copy link
Collaborator

Adda0 commented Oct 14, 2023

Let me know if you want to remove the commented out lines or merge the PR right away.

@Adda0 Adda0 merged commit f2da27e into devel Oct 14, 2023
12 checks passed
@Adda0 Adda0 deleted the jupyter-visualization branch October 14, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants