-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter notebook for visualization #370
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #370 +/- ##
==========================================
+ Coverage 71.80% 71.82% +0.01%
==========================================
Files 30 30
Lines 3643 3642 -1
Branches 836 834 -2
==========================================
Hits 2616 2616
Misses 735 735
+ Partials 292 291 -1
☔ View full report in Codecov by Sentry. |
This was badly needed. I will review the PR later today as soon as I can. From the quick glance, the PR seems nice. |
@kilohsakul maybe wanted to include such a notebook to the paper. Lukas, please look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think we should add one of the examples to the paper.
Krasne! Jeste by to fakt mohlo kreslit horizontalne. |
I think it is ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fine, probably remove those commented lines though, if they are not used anywhere.
Let me know if you want to remove the commented out lines or merge the PR right away. |
Notebook showing possibilities of automata visualisation in mata.