Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for nft::insert_levels(). All tests pass. #393

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

koniksedy
Copy link
Collaborator

This PR includes:

  • A bug fix for the function mata::nft::insert_level().
    • The main issue was that the result transducer was constructed with an empty delta (on line 387). Consequently, it did not know which number to choose for the new state created using the method mata::nfa::add_state(). This led to the creation of inner states (states with new levels) with the same names as existing states, thereby causing issues with delta.
  • Repairs to the expected transducer (on line 638). This transducer contained END_MARKER, even though these markers were only present at synchronization levels.
  • Uncommenting the remaining tests for mata::nft::replace_reluctant_literal(). All tests pass.

@koniksedy koniksedy requested a review from Adda0 March 3, 2024 18:16
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.16%. Comparing base (793521e) to head (be63c6b).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           reluctant_replace     #393      +/-   ##
=====================================================
- Coverage              74.28%   74.16%   -0.13%     
=====================================================
  Files                     43       43              
  Lines                   5456     5457       +1     
  Branches                1215     1215              
=====================================================
- Hits                    4053     4047       -6     
- Misses                   955      966      +11     
+ Partials                 448      444       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry, I did not expect you to try to fix the remaining uncommented tests except for the one we talked about. Those other tests were just copy-pasted from the previous test case and not modified yet to try to apply the full replace-all procedure.

@Adda0 Adda0 merged commit 87fc776 into reluctant_replace Mar 3, 2024
17 of 18 checks passed
@Adda0 Adda0 deleted the insert_levels-bug_fix branch March 3, 2024 18:34
Adda0 pushed a commit that referenced this pull request Mar 6, 2024
Adda0 pushed a commit that referenced this pull request Mar 28, 2024
Adda0 pushed a commit that referenced this pull request Apr 15, 2024
Adda0 pushed a commit that referenced this pull request Nov 18, 2024
Adda0 pushed a commit that referenced this pull request Nov 21, 2024
Adda0 pushed a commit that referenced this pull request Nov 21, 2024
Adda0 pushed a commit that referenced this pull request Nov 22, 2024
Adda0 pushed a commit that referenced this pull request Dec 2, 2024
hiraethese pushed a commit to hiraethese/mata that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants