-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for nft::insert_levels(). All tests pass. #393
Conversation
…eluctant_literal() uncommented and passing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## reluctant_replace #393 +/- ##
=====================================================
- Coverage 74.28% 74.16% -0.13%
=====================================================
Files 43 43
Lines 5456 5457 +1
Branches 1215 1215
=====================================================
- Hits 4053 4047 -6
- Misses 955 966 +11
+ Partials 448 444 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry, I did not expect you to try to fix the remaining uncommented tests except for the one we talked about. Those other tests were just copy-pasted from the previous test case and not modified yet to try to apply the full replace-all procedure.
…eluctant_literal() uncommented and passing. (#393)
…eluctant_literal() uncommented and passing. (#393)
…eluctant_literal() uncommented and passing. (#393)
…eluctant_literal() uncommented and passing. (#393)
…eluctant_literal() uncommented and passing. (#393)
…eluctant_literal() uncommented and passing. (#393)
…eluctant_literal() uncommented and passing. (#393)
…eluctant_literal() uncommented and passing. (#393)
…eluctant_literal() uncommented and passing. (VeriFIT#393)
This PR includes:
mata::nft::insert_level()
.result
transducer was constructed with an empty delta (on line 387). Consequently, it did not know which number to choose for the new state created using the methodmata::nfa::add_state()
. This led to the creation of inner states (states with new levels) with the same names as existing states, thereby causing issues with delta.expected
transducer (on line 638). This transducer containedEND_MARKER
, even though these markers were only present at synchronization levels.mata::nft::replace_reluctant_literal()
. All tests pass.