Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate complement using brzozowski minimization from classical complement #410

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

Adda0
Copy link
Collaborator

@Adda0 Adda0 commented Jun 25, 2024

This PR:

This PR resolves #342.

@Adda0 Adda0 requested a review from jurajsic June 25, 2024 08:24
Copy link
Member

@jurajsic jurajsic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

include/mata/nfa/nfa.hh Outdated Show resolved Hide resolved
include/mata/nfa/nfa.hh Outdated Show resolved Hide resolved
src/nfa/complement.cc Show resolved Hide resolved
src/nfa/nfa.cc Outdated Show resolved Hide resolved
src/nfa/operations.cc Show resolved Hide resolved
@Adda0 Adda0 requested a review from kilohsakul June 25, 2024 09:03
@Adda0 Adda0 force-pushed the separate_complement_brzozowski branch from 599500a to 6fa5bdd Compare June 25, 2024 10:33
@jurajsic
Copy link
Member

jurajsic commented Jul 4, 2024

I think we can merge this.

@Adda0
Copy link
Collaborator Author

Adda0 commented Jul 4, 2024

I will. I discussed with Lukáš that we will review the most important changes later on when he has a bit of time to spare.

@Adda0 Adda0 merged commit 4c41899 into devel Jul 8, 2024
18 checks passed
@Adda0 Adda0 deleted the separate_complement_brzozowski branch July 8, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debordelize complement
2 participants