Get symbols to work with #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurajsic
reviewed
Jul 9, 2024
| @@ -1208,6 +1202,12 @@ std::set<mata::Word> mata::nfa::Nfa::get_words(unsigned max_length) { | |||
| return result; | |||
| } | |||
|
|
|||
| OrdVector<Symbol> mata::nfa::get_symbols_to_work_with(const Nfa& nfa, const mata::Alphabet *const shared_alphabet) { | |||
There was a problem hiding this comment.
Shouldn't this be return const OrdVector<Symbol>&? Or do those functions (get_alphabet_symbols() and get_used_symbols()) create the ordvector and return by value?
There was a problem hiding this comment.
No. It is constructing the set of symbols, either from alphabets (which themselves do not necessarily have a handy OrdVector<Symbol> allocated either), or constructing a new set directly from the transition relation. Therefore, a new set has to be allocated.
jurajsic
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
nullptr(by default if the alphabet is not passed), from an alphabet shared between NFAs pointed to byNfa::alphabet, or if it is alsonullptr, from transition relation (reading all symbols used in transition relation).make_complete()callable without any arguments.make_complete()function to pass alphabet as a pointer, as in all other functions in Mata.