Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatness checking #423

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Flatness checking #423

merged 3 commits into from
Jul 15, 2024

Conversation

vhavlena
Copy link
Collaborator

Adding a new method for checking flatness of an NFA (is_flat).

@vhavlena vhavlena linked an issue Jul 12, 2024 that may be closed by this pull request
Method for checking flatness #416
Closed
@vhavlena vhavlena requested review from jurajsic and Adda0 July 12, 2024 10:05
Adda0
Adda0 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I like that the implementation of the Tarjan's algorithm allows for these operations thanks to the callbacks.

@Adda0 Adda0 merged commit a313a58 into devel Jul 15, 2024
18 checks passed
@Adda0 Adda0 deleted the is_flat branch July 15, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurajsic jurajsic jurajsic approved these changes

@Adda0 Adda0 Adda0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method for checking flatness
3 participants
@vhavlena @jurajsic @Adda0