Fix counterexamples for inclusion #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurajsic
changed the title
is_included_antichains
|
It seems that there is significant slowdown while generating counterexamples, see VeriFIT/z3-noodler#183 |
vhavlena
approved these changes
Oct 25, 2024
| @@ -206,8 +206,25 @@ public: | |||
| */ | |||
| Nfa& trim(StateRenaming* state_renaming = nullptr); | |||
|
|
|||
| /** | |||
| * @brief Returns vector ret where ret[q] is the length of the shortest path from any initial state to q | |||
| */ | |||
| std::vector<State> distances_from_initial() const; | |||
There was a problem hiding this comment.
It would be nice if we have some general BFS/DFS method parameterized by callbacks (in a similar fashion as for Tarjan). All these functions such as distances_from_initial or distances_to_final could be easily expressible by this and you wouldn't need to write BFS/DFS all over again.
There was a problem hiding this comment.
Created an issue from this: #446.
Adda0
approved these changes
Oct 25, 2024
Co-authored-by: David Chocholatý <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes counterexamples for antichain inclusion algorithm (both the word and path were incorrect) and for naive algorithm it fixes the path in the counterexamples.