Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating subfolders for integration tests sources #448

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Adda0
Copy link
Collaborator

@Adda0 Adda0 commented Oct 29, 2024

This pull request includes a change to the tests-integration/CMakeLists.txt file to improve the flexibility of how source files are included in the build process.

Build process improvement:

  • tests-integration/CMakeLists.txt: Modified the file(GLOB SOURCES "src/*.cc") command to file(GLOB SOURCES "src/**/*.cc") to include source files in subdirectories.

@Adda0 Adda0 requested a review from jurajsic October 29, 2024 09:32
@jurajsic
Copy link
Member

Why is everything failing?

@Adda0 Adda0 force-pushed the integration-tests-subfolders branch from 451e85c to 5f69e28 Compare October 29, 2024 12:44
@Adda0
Copy link
Collaborator Author

Adda0 commented Oct 29, 2024

It appears that globbing in CMake is not as powerful as I anticipated. A considerable refactor was needed.

Copy link
Member

@jurajsic jurajsic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (if it is finished :D)

@Adda0 Adda0 merged commit 0cdff37 into devel Nov 4, 2024
18 checks passed
@Adda0 Adda0 deleted the integration-tests-subfolders branch November 4, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants