Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing automata with no transitions #449

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Parsing automata with no transitions #449

merged 1 commit into from
Oct 30, 2024

Conversation

koniksedy
Copy link
Collaborator

This PR:

@koniksedy koniksedy requested review from jurajsic and Adda0 October 30, 2024 14:28
@Adda0
Copy link
Collaborator

Adda0 commented Oct 30, 2024

We already discussed this today. Have you later tried this from the Python interface, too?

@koniksedy
Copy link
Collaborator Author

Yes and it worked.

Adda0
Adda0 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@Adda0 Adda0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem good to me. It should indeed solve the problem in both opened issues.

@Adda0 Adda0 merged commit 84ecd6a into devel Oct 30, 2024
18 checks passed
@Adda0 Adda0 deleted the no_trans branch October 30, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adda0 Adda0 Adda0 approved these changes

@jurajsic jurajsic jurajsic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing trivial .mata files can coredump Killed when parsing file with an empty automaton
3 participants
@koniksedy @Adda0 @jurajsic