Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CI, Update Gradle and dependencies. #72

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Clean up CI, Update Gradle and dependencies. #72

merged 6 commits into from
Oct 20, 2023

Conversation

Kichura
Copy link
Member

@Kichura Kichura commented Oct 20, 2023

  1. Updates the GitHub workflow script to be cleaner and morely efficient for uploading artifacts,
  2. Upstreams the .gitignore file to reflect EnZa's BaseProject repo a bit,
  3. Replaces the old ViaForge issues URL with the new one,
  4. Adds G1GC to the gradle properties as compiling ViaForge has turned to be unexpectedly heavy,
  5. Adds a network timeout and source validation for the gradle-wrapper properties file,
  6. Upstreams the Via* suite to dev builds,
  7. Upstreams the gradlew scripts,
  8. Updates Forge 1.12.2 to 23.5.2860,
  9. Updates Forge 1.16.5 to 36.2.39.

^ While the above sounds fair-game and all, i did manage to catch up on some CI failures and as result certain dependencies had to be set back rather than go all-in and upgrade fully:

  1. Gradle could not be updated to 8.4 as legacy forge is not compatible with it which means 7.5.1 will be used instead,
  2. Because Gradle is now 7.5.1 instead, The shadow dependency had to be set back to 7.1.2 instead as a result too,
  3. MinecraftForge has been set back to 5.+ as 6.+ would've been compatible with Gradle 8.x but makes legacy forge fail anyways.

@FlorianMichael FlorianMichael merged commit 21f6507 into ViaVersion:master Oct 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants