Fix MemberExpression and add MethodCalls #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsmock
force-pushed
the
more-functions
branch
from
db8ee08 to
d1ad8e8
Compare
Merged
kanaka
requested changes
Oct 8, 2024
jonsmock
force-pushed
the
more-functions
branch
from
d1ad8e8 to
58879be
Compare
Previously MemberExpression prohibited something like `foo(env).b.c`,
because `foo(env)` is a FunctionCall, not a ContextName.
We now require that MemberExpression contains at least one Property
access. In order to match `foo(env).b.c` correctly, we must move
MemberExpression to the first matching position of UnaryExpression;
otherwise, FunctionCall will match `foo(env)`, followed by an end of
input error when attempting to match `.b.c`.
Choosing for now to allow member access on Value, but that is up for
debate (ex: `{"a": 3}.a`).
Initial method call support with the first supported methods including `toString` and `count`. MemberExpression supports both MethodCall and Property, so that we can greedily parse expressions like `x.foo().bar.baz().z`. If we attempt to separate methods and properties into separate expression types, the MemberExpression will attempt to capture `foo` and `baz` as member accesses, and we run into end of input errors for the method calls. MemberExpression evaluation needs to also evaluate its MethodCall children, so we can pass the referenced object of the MethodCall. This works but has the drawback of needing to check for uncaught errors again inside the MemberExpression evaluation.
Upgrade cljs-bean when using shadow-cljs to get :keywordize-keys functionality.
jonsmock
force-pushed
the
more-functions
branch
from
58879be to
b0b5a8e
Compare
|
Gah, thanks! I've moved the offending examples/tests to the last commit, where those functions are introduced (and fixed some typos in the commit messages). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #15, only last 3 commits are new.
Fixes a bug in previous member access to allow things like
fromJSON(...).foo. Previously onlyfoo.a.b.cwould work, but you could not access members on values returned by functions.Adds MethodCall to the ast to support methods like
x.toString()andx.count().Adds some additional functions for strings and conversions.