-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to display 32 bit integer #171
base: master
Are you sure you want to change the base?
Conversation
Also, what's about the bottom bus? Is it just there for decoration? I want it to be obvious, and for that you'd probably need an indicator inside the GUI and not render the third bus |
I may rework some code so I'll add support for up to 48-bit integers: |
Okay, now correcting mistakes you've mentioned. |
Looks good so far, but I'd prefer if you could configure it inside the GUI somehow... What about this: You combine short and int (+48 bit?) into one category and then allow to freely configure the sides. If you only select one its going to be short, two is int and three is your 48bit integer. I'd probably do this with three mode switches that work similar to the CAD, around my render of the segment. Adding to this, you'd also have to change I'm going to pull it anyways, this is just if you want to do it yourself. |
Alright, but I'm very bad at GUI coding. I'll try, though. |
How is progress on this going, @Awesome2K? |
Well, no luck with GUI. My text just doesn't get rendered. Still trying... |
@Awesome2K If you have any questions on it I'd be glad to answer them, just join IRC (server: irc.esper.net, channel: #sapphire) |
public static final int MODE_INT_UNSIGNED = 5; | ||
public static final int MODE_FLOAT = 6; | ||
public static final int MODE_BINARY_STRING = 7; | ||
public static final int MODE_MANUAL = 8; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can't just change these, it would break backwards compatibility. You need to add int to the end as 7/8
I'd still prefer a solution where you can change the input sides via the GUI, but I'm going to pull it like this if you don't want to do that. |
Added both signed and unsigned ints.
Top bus = 16 upper bits
Right bus = 16 lower bits
May be kinda buggy, but everything works fine for me.
(Related to issue #170 )
Edit: I can reformat/refactor some code if needed.