Register tests directory for rails stats

[javierav]

What are you trying to accomplish?

After the introduction of PR #2081, the tests directory was missing in rails stats.

[joelhawksley]

@javierav thanks for writing up a PR here, but I'm confused: are you saying that previously rails stats would include tests for components? I don't remember that ever being the case.

[javierav]

@javierav thanks for writing up a PR here, but I'm confused: are you saying that previously rails stats would include tests for components? I don't remember that ever being the case.

No, sorry for the confusion. What I meant was that the previous PR adds the "app/components" folder to rails stats but it forgot to add the "test/components" folder if it exists, which is what this PR does.

[joelhawksley]

@javierav got it. I'm hesitant to add test/components if it wasn't there before. I believe rails stats is meant to report on the contents of app. Have you seen it report on other test-related objects?

[javierav]

@joelhawksley sure! For example already exists in Rails 6.0 or RSpec

This is the output for a Rails 7.2 empty app:

+----------------------+--------+--------+---------+---------+-----+-------+
| Name                 |  Lines |    LOC | Classes | Methods | M/C | LOC/M |
+----------------------+--------+--------+---------+---------+-----+-------+
| Controllers          |      4 |      3 |       1 |       0 |   0 |     0 |
| Helpers              |      2 |      2 |       0 |       0 |   0 |     0 |
| Jobs                 |      7 |      2 |       1 |       0 |   0 |     0 |
| Models               |      3 |      3 |       1 |       0 |   0 |     0 |
| Mailers              |      4 |      4 |       1 |       0 |   0 |     0 |
| Channels             |      8 |      8 |       2 |       0 |   0 |     0 |
| Views                |     85 |     55 |       0 |       1 |   0 |    53 |
| Stylesheets          |     15 |     15 |       0 |       0 |   0 |     0 |
| JavaScript           |     23 |     16 |       0 |       0 |   0 |     0 |
| Libraries            |      0 |      0 |       0 |       0 |   0 |     0 |
| Controller tests     |      0 |      0 |       0 |       0 |   0 |     0 |
| Helper tests         |      0 |      0 |       0 |       0 |   0 |     0 |
| Model tests          |      0 |      0 |       0 |       0 |   0 |     0 |
| Mailer tests         |      0 |      0 |       0 |       0 |   0 |     0 |
| Channel tests        |     13 |      5 |       1 |       0 |   0 |     0 |
| Integration tests    |      0 |      0 |       0 |       0 |   0 |     0 |
| System tests         |      0 |      0 |       0 |       0 |   0 |     0 |
+----------------------+--------+--------+---------+---------+-----+-------+
| Total                |    164 |    113 |       7 |       1 |   0 |   111 |
+----------------------+--------+--------+---------+---------+-----+-------+
  Code LOC: 108     Test LOC: 5     Code to Test Ratio: 1:0.0

[joelhawksley]

@javierav no kidding! Well, then let's figure out how to land this one ❤️

Have you tested it with rspec? It looks like we're hardcoding test/components, but wouldn't it be spec/components if rspec is being used?

[javierav]

@joelhawksley Yes, initially the test/components path is hardcoded because there is no such thing as ViewComponent::Base.view_component_path for tests.

In this case, we just need to check if the project is using Rails default tests (minitest) to add the test/components path, since if the project is using RSpec, RSpec itself will be in charge of adding its paths to the stats here

Unfortunately, Rails only adds a series of initial directories to the stats, and test/components is not among them.