Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] core: secure cookie for session_id #2

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

ndd-odoo
Copy link
Member

-The Secure attribute for sensitive cookies in an HTTPS session is not set, which could cause users to send those cookies in plaintext over an insecure encrypted transmission (HTTP).

Description of the issue/feature this PR addresses: https://viindoo.com/web#id=92024&cids=1&menu_id=89&model=project.task&view_type=form

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script ⚠️ Failed PR/Commit is failed when run script and removed 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels Jun 25, 2024
@viinbot
Copy link

viinbot commented Jun 25, 2024

@duong77476-viindoo Viindoo Test Suite has failed!

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script and removed ⚠️ Failed PR/Commit is failed when run script 🚀 Queue PR/Commit is added in build queue labels Jun 25, 2024
@viinbot
Copy link

viinbot commented Jun 25, 2024

@duong77476-viindoo Viindoo Test Suite has failed!

@viinbot viinbot added ⚠️ Failed PR/Commit is failed when run script and removed 🚀 Building PR/Commit is start building all step in script labels Jun 25, 2024
@ndd-odoo
Copy link
Member Author

@viinbot rebase

@royle-vietnam
Copy link

@viinbot rebuild

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue and removed ⚠️ Failed PR/Commit is failed when run script labels Jun 26, 2024
@viinbot
Copy link

viinbot commented Jun 26, 2024

@royle-viindoo PR in the queue to wait for rebuild!

@viinbot
Copy link

viinbot commented Jun 26, 2024

@duong77476-viindoo The rebase process failed, failed with output:

Cloning into '/mnt/volume_sgp1_05/runbot/static/sources_tmp/Viindoo-customer-s5t-odoo'...
fatal: packfile /mnt/volume_sgp1_05/runbot/static/sources_tmp/Viindoo-customer-s5t-odoo/.git/objects/pack/pack-72c110e10da21a473702a576d6e11d975da10c97.pack cannot be mapped, check sys.vm.max_map_count and/or RLIMIT_DATA: Cannot allocate memory
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'


@viinbot viinbot added 🚀 Building PR/Commit is start building all step in script ⚠️ Failed PR/Commit is failed when run script and removed 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels Jun 26, 2024
@viinbot
Copy link

viinbot commented Jun 26, 2024

@duong77476-viindoo Viindoo Test Suite has failed!

-The Secure attribute for sensitive cookies in an HTTPS session is not
set, which could cause users to send those cookies in plaintext over an
insecure encrypted transmission (HTTP).
@ndd-odoo ndd-odoo force-pushed the v15_imp_core_secure_cookie branch from af45e2b to 3dac545 Compare June 27, 2024 06:15
@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script and removed ⚠️ Failed PR/Commit is failed when run script 🚀 Queue PR/Commit is added in build queue labels Jun 27, 2024
@viinbot viinbot added ⚠️ Failed PR/Commit is failed when run script and removed 🚀 Building PR/Commit is start building all step in script labels Jun 27, 2024
@viinbot
Copy link

viinbot commented Jun 27, 2024

@duong77476-viindoo Viindoo Test Suite has failed!

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script and removed ⚠️ Failed PR/Commit is failed when run script 🚀 Queue PR/Commit is added in build queue labels Jun 27, 2024
@viinbot
Copy link

viinbot commented Jun 27, 2024

@duong77476-viindoo Viindoo Test Suite has passed!

@viinbot viinbot added 🚀 Running PR/Commit is done for everything and ready for manually test and removed 🚀 Building PR/Commit is start building all step in script labels Jun 27, 2024
@royle-vietnam royle-vietnam merged commit 4fc6eda into Viindoo:15.0 Jun 28, 2024
1 check passed
@viinbot viinbot added 🚩 Done PR/Commit is finished manually test and closed instance and removed 🚀 Running PR/Commit is done for everything and ready for manually test labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚩 Done PR/Commit is finished manually test and closed instance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants