forked from Viindoo/odoo
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] core: secure cookie for session_id #2
Merged
royle-vietnam
merged 2 commits into
Viindoo:15.0
from
ndd-odoo:v15_imp_core_secure_cookie
Jun 28, 2024
Merged
[IMP] core: secure cookie for session_id #2
royle-vietnam
merged 2 commits into
Viindoo:15.0
from
ndd-odoo:v15_imp_core_secure_cookie
Jun 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@duong77476-viindoo Viindoo Test Suite has failed! |
@duong77476-viindoo Viindoo Test Suite has failed! |
@viinbot rebase |
@viinbot rebuild |
@royle-viindoo PR in the queue to wait for rebuild! |
@duong77476-viindoo The rebase process failed, failed with output:
|
@duong77476-viindoo Viindoo Test Suite has failed! |
-The Secure attribute for sensitive cookies in an HTTPS session is not set, which could cause users to send those cookies in plaintext over an insecure encrypted transmission (HTTP).
af45e2b
to
3dac545
Compare
@duong77476-viindoo Viindoo Test Suite has failed! |
royle-vietnam
approved these changes
Jun 27, 2024
@duong77476-viindoo Viindoo Test Suite has passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-The Secure attribute for sensitive cookies in an HTTPS session is not set, which could cause users to send those cookies in plaintext over an insecure encrypted transmission (HTTP).
Description of the issue/feature this PR addresses: https://viindoo.com/web#id=92024&cids=1&menu_id=89&model=project.task&view_type=form
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr