[FIX] web: update jQuery to 3.6.3 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version of jQuery fixes a number of vulnerabilities in jQuery compared to 3.3.1 at https://security.snyk.io/package/npm/jquery/3.3.1 Some legacy list tests related to the handle widget have been skipped, we consider this acceptable because: - there are no remaining uses of the handle widget in a legacy list view in the code base. The only remaining usage of the legacy list view is in the SelectCreateDialog legacy, which is only used in our code base by the very few legacy client actions that will be converted before v17 - the tests are only broken in enterprise, and the widget appears to work fine in practice, suggesting a problem with the way tests drag and drop rather than an actual problem with the code - spending time to debug tests that will be obsolete within the next few months and also appear to not correlate to an actual breakage of the functionality is not worth it. task-2291793 closes odoo#106960 Signed-off-by: Aaron Bohy (aab) <[email protected]>
To test which browser is currently running, jquery performs some checks when it starts, by doing invalid queryselectors. Depending on which selectors crashes, it can determinate if it is running in an old browser and need to activate some part of the code to support them. This would not be a big deal, except that it makes the life of some developers much more difficult: we can no longer easily reload a page with a "Pause on exception" setting to debug odoo. Doing so works, but the workflow is polluted by 3 errors initially. It is so common that I propose to simply remove the checks. This should be acceptable, since Odoo does not work on old browser versions anyway We are talking about firefox 5, opera 11 or "Gecko", for a commit that is at least 11 years old closes odoo#136013 Signed-off-by: Samuel Degueldre (sad) <[email protected]>
viinbot
added
🚀 Queue
|
@royle-viindoo Viindoo Test Suite has failed! |
viinbot
added
🚀 Queue
|
@royle-viindoo Viindoo Test Suite has passed! |
viinbot
added
🚩 Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr