Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] core: disable debug mode #4

Merged
merged 2 commits into from
Jun 27, 2024
Merged

[IMP] core: disable debug mode #4

merged 2 commits into from
Jun 27, 2024

Conversation

ndd-odoo
Copy link
Member

@ndd-odoo ndd-odoo commented Jun 25, 2024 •
edited
Loading

Description of the issue/feature this PR addresses: https://viindoo.com/web#id=92026&cids=1&menu_id=89&model=project.task&view_type=form

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script ⚠️ Failed PR/Commit is failed when run script and removed 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels Jun 25, 2024
@viinbot
Copy link

viinbot commented Jun 25, 2024

@duong77476-viindoo Viindoo Test Suite has failed!

royle-vietnam
royle-vietnam reviewed Jun 26, 2024
View reviewed changes
Copy link

@royle-vietnam royle-vietnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duong77476-viindoo em xem ảnh khách đính kèm, chỉ cần xóa dòng 512 và dòng 518 sửa thành return View.render_public_asset(xmlid) là đủ

@ndd-odoo
Copy link
Member Author

View.render_public_asset

@royle-viindoo e thử như a rồi mà e dùng con khỉ vẫn tắt được như thường anh ạ

video-2024-06-26_15.18.39.mp4

@royle-vietnam
Copy link

View.render_public_asset

@royle-viindoo e thử như a rồi mà e dùng con khỉ vẫn tắt được như thường anh ạ

video-2024-06-26_15.18.39.mp4

@duong77476-viindoo cái tính năng debug là tính năng hay ho của Odoo, họ chỉ báo lỗi ở đó, thì chỉ cần xử ở đó thôi, em cứ xử thế đi

@ndd-odoo ndd-odoo force-pushed the v15_core_debug_mode branch from 6d5e348 to 82ebe4f Compare June 26, 2024 08:25
@viinbot viinbot added 🚀 Queue PR/Commit is added in build queue and removed ⚠️ Failed PR/Commit is failed when run script labels Jun 26, 2024
@ndd-odoo ndd-odoo changed the title [IMP] core: disable debug mode for non admin user [IMP] core: disable debug mode Jun 26, 2024
royle-vietnam
royle-vietnam approved these changes Jun 26, 2024
View reviewed changes
Copy link

@royle-vietnam royle-vietnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viinbot viinbot added 🚀 Building PR/Commit is start building all step in script and removed 🚀 Queue PR/Commit is added in build queue 🚀 Building PR/Commit is start building all step in script labels Jun 26, 2024
@viinbot
Copy link

viinbot commented Jun 26, 2024

@duong77476-viindoo Viindoo Test Suite has passed!

@viinbot viinbot added the 🚀 Running PR/Commit is done for everything and ready for manually test label Jun 26, 2024
@royle-vietnam royle-vietnam merged commit 63799d1 into Viindoo:15.0 Jun 27, 2024
1 check passed
@viinbot viinbot added 🚩 Done PR/Commit is finished manually test and closed instance and removed 🚀 Running PR/Commit is done for everything and ready for manually test labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royle-vietnam royle-vietnam royle-vietnam approved these changes

Assignees
No one assigned
Labels
🚩 Done PR/Commit is finished manually test and closed instance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndd-odoo @viinbot @royle-vietnam