Max T joints #48
Open
Max T joints #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VikingScientist
force-pushed
the
max-T-joints
branch
from
30252c0 to
d24c3b1
Compare
|
A sample test code using this can be found at https://github.com/VikingScientist/LRsplines/blob/tmp/Apps/TestMaxTjoints.cpp BEFORE calling
AFTER
|
VikingScientist
force-pushed
the
max-T-joints
branch
from
a087ab1 to
a02121d
Compare
VikingScientist
force-pushed
the
max-T-joints
branch
from
8b404fc to
cba6956
Compare
|
There were some initial flaws with this implementation, but they should be fixed now including better test coverage in 01c1ff3 Also the wierd refinement propegation is now in order. This is the results after requesting "maxTjoints" on the initial mesh from the screenshot.
It has also been tested when compiled and used against IFEM. This should be ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not sufficiently tested, so use at your own peril.
But the structure and logic for max-T-joint logic is in place so you could have a look at it. It will also probably need some accompanying changes on the IFEM side to be properly integrated.