formatJson options

Vincit · Apr 10, 2021 · b8505ee · b8505ee
1 parent 260b284
commit b8505ee
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/doc/api/model/instance-methods.md b/doc/api/model/instance-methods.md
@@ -747,9 +747,9 @@ There are a couple of requirements for the implementation:
 
 ```js
 class Person extends Model {
-  $formatJson(json) {
+  $formatJson(json, options) {
     // Remember to call the super class's implementation.
-    json = super.$formatJson(json);
+    json = super.$formatJson(json, options);
     // Do your conversion here.
     return json;
   }
@@ -768,9 +768,10 @@ There are a couple of requirements for the implementation:
 
 ##### Arguments
 
-| Argument | Type   | Description                      |
-| -------- | ------ | -------------------------------- |
-| json     | Object | The JSON POJO in internal format |
+| Argument | Type   | Description                                              |
+| -------- | ------ | -------------------------------------------------------- |
+| json     | Object | The JSON POJO in internal format                         |
+| options  | Object | Formatting options from toJSON's options.format property |
 
 ##### Return value
 

diff --git a/lib/model/Model.js b/lib/model/Model.js
@@ -127,7 +127,7 @@ class Model {
     return json;
   }
 
-  $formatJson(json) {
+  $formatJson(json, options) {
     return json;
   }
 

diff --git a/lib/model/modelToJson.js b/lib/model/modelToJson.js
@@ -15,10 +15,11 @@ function toJson(model, optIn) {
     pick: null,
     omitFromJson: model.$omitFromJson() || null,
     cloneObjects: modelClass.cloneObjectAttributes,
+    format: optIn && optIn.format
   };
 
   let json = toExternalJsonImpl(model, opt);
-  json = model.$formatJson(json);
+  json = model.$formatJson(json, opt.format);
 
   return json;
 }

diff --git a/typings/objection/index.d.ts b/typings/objection/index.d.ts
@@ -1267,6 +1267,7 @@ declare namespace Objection {
 
   export interface ToJsonOptions extends CloneOptions {
     virtuals?: boolean | string[];
+    format?: Pojo
   }
 
   export interface ValidatorContext {
@@ -1695,7 +1696,7 @@ declare namespace Objection {
     $formatDatabaseJson(json: Pojo): Pojo;
     $parseDatabaseJson(json: Pojo): Pojo;
 
-    $formatJson(json: Pojo): Pojo;
+    $formatJson(json: Pojo, opt?: Pojo): Pojo;
     $parseJson(json: Pojo, opt?: ModelOptions): Pojo;
 
     $beforeValidate(jsonSchema: JSONSchema, json: Pojo, opt: ModelOptions): JSONSchema;