Fix potential exception by removing put outside computeIfAbsent #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.classes is a ConcurrentHashMap. The originalCode try to put something into this.classes inside computeIfAbsent. computeIfAbsent will acquire lock of certain slot of the ConcurrentHashMap. If clazz.qualifiedName end up in the same slot, it will also try to accquire the same lock, which is already held by the same thread, will cause "java.lang.IllegalStateException: Recursive update"
demo.zip
This is a small jar file that will trigger the excetpion.