Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a multitude of crashes and exceptions during Kotlin decompilation #339

Merged
merged 7 commits into from
Jan 25, 2024

Conversation

sschr15
Copy link
Member

@sschr15 sschr15 commented Jan 21, 2024

I have run a diff against the decompilation of Kotlin's standard library on version 1.9.20 comparing these fixes against the current 1.10 commit

Copy link

github-actions bot commented Jan 21, 2024

Test Results

   27 files  ± 0     27 suites  ±0   1m 34s ⏱️ ±0s
2 458 tests  - 98  2 458 ✅  - 98  0 💤 ±0  0 ❌ ±0 
3 753 runs  ± 0  3 753 ✅ ± 0  0 💤 ±0  0 ❌ ±0 

Results for commit da10113. ± Comparison against base commit 773cd96.

♻️ This comment has been updated with latest results.

@jaskarth jaskarth added Priority: Medium Medium priority Subsystem: Plugins Anything concerning the plugins system or plugin code Type: Enhancement New feature or request labels Jan 21, 2024
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Thanks!

@jaskarth jaskarth merged commit ffebfcd into develop/1.10.0 Jan 25, 2024
11 checks passed
@jaskarth jaskarth deleted the feature/kotlin/fixes/exceptions branch April 4, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Medium priority Subsystem: Plugins Anything concerning the plugins system or plugin code Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants