Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map all bytecode in range #386

Merged
merged 1 commit into from
May 1, 2024
Merged

Map all bytecode in range #386

merged 1 commit into from
May 1, 2024

Conversation

jaskarth
Copy link
Member

Fixes many bytecode mapping bugs. PR since >300 tests are updated.

@jaskarth jaskarth added Priority: Medium Medium priority Subsystem: Parsing Anything concerning how bytecode is parsed and read bugfix Fixes a bug labels Apr 30, 2024
Copy link

github-actions bot commented Apr 30, 2024

Test Results

    9 files   -     9      9 suites   - 9   31s ⏱️ -32s
1 266 tests  -   653  1 265 ✅  -   654  0 💤 ±0  1 ❌ +1 
1 267 runs   - 1 267  1 266 ✅  - 1 268  0 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 799766d. ± Comparison against base commit e9ce490.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Earthcomputer Earthcomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Most of the changes in the tests are caused by the old code not properly mapping all of the last instruction in each basic block. I reviewed using a modified version of the fix that only added the first byte of the last instruction of the basic block, and there were only 31 changed tests left to review. I went through them and they look good. This seemed to be the root cause of quite a few line mapping issues we had.

@jaskarth jaskarth force-pushed the fix/bytecode-ranges branch from ca264f0 to 799766d Compare May 1, 2024 03:08
@jaskarth jaskarth force-pushed the fix/bytecode-ranges branch from 799766d to 6eb62fd Compare May 1, 2024 03:24
@jaskarth
Copy link
Member Author

jaskarth commented May 1, 2024

Thanks for the review! Will merge now.

@jaskarth jaskarth merged commit fa6317a into develop/1.11.0 May 1, 2024
6 checks passed
@jaskarth jaskarth deleted the fix/bytecode-ranges branch May 1, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug Priority: Medium Medium priority Subsystem: Parsing Anything concerning how bytecode is parsed and read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants