Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable used in switch head not being inlined #399

Conversation

coehlrich
Copy link
Contributor

Fixes cases where vineflower creates an unitialized variable and checks if it's non null then casting that unitialized variable then putting the exprent that should be in the switch head above the switch statement with the variable in the switch head being the casted null variable.

@jaskarth jaskarth added Priority: Medium Medium priority Subsystem: Variables Anything concerning variables, types, assignments, and casting bugfix Fixes a bug labels May 20, 2024
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this change! The fix itself looks fine to me, I have mostly stylistic changes here.

Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jaskarth jaskarth merged commit 1394013 into Vineflower:develop/1.11.0 May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug Priority: Medium Medium priority Subsystem: Variables Anything concerning variables, types, assignments, and casting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants