Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow plugins to change decompiled file extensions #420

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Allow plugins to change decompiled file extensions #420

merged 4 commits into from
Aug 23, 2024

Conversation

sschr15
Copy link
Member

@sschr15 sschr15 commented Aug 21, 2024

No description provided.

@sschr15 sschr15 requested a review from jaskarth August 21, 2024 16:18
@sschr15 sschr15 added Type: Enhancement New feature or request Subsystem: IO Anything concerning the File I/O system labels Aug 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2024 •
edited
Loading

Test Results

   18 files  ±0     18 suites  ±0   1m 3s ⏱️ ±0s
1 926 tests ±0  1 925 ✅ ±0  1 💤 ±0  0 ❌ ±0 
2 548 runs  ±0  2 546 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 389f388. ± Comparison against base commit 966edd5.

♻️ This comment has been updated with latest results.

jaskarth
jaskarth requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I've added some comments here.

src/org/jetbrains/java/decompiler/api/plugin/LanguageSpec.java Outdated Show resolved Hide resolved
testFixtures/org/jetbrains/java/decompiler/SingleClassesTestBase.java Outdated Show resolved Hide resolved
testFixtures/org/jetbrains/java/decompiler/SingleClassesTestBase.java Outdated Show resolved Hide resolved
@sschr15 sschr15 self-assigned this Aug 23, 2024
@sschr15 sschr15 requested a review from jaskarth August 23, 2024 15:13
jaskarth
jaskarth approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@jaskarth jaskarth merged commit a6f7865 into develop/1.11.0 Aug 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaskarth jaskarth jaskarth approved these changes

Assignees

@sschr15 sschr15

Labels
Subsystem: IO Anything concerning the File I/O system Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sschr15 @jaskarth