Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for labeled blocks in constructor #437

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Add test for labeled blocks in constructor #437

merged 1 commit into from
Dec 4, 2024

Conversation

Earthcomputer
Copy link
Contributor

This incorrectly decompiles to a super() call inside of the labelled block, add a test so it can be fixed later

@jaskarth jaskarth added Priority: Medium Medium priority Type: Unit Tests New or modified unit tests labels Dec 4, 2024
jaskarth
jaskarth approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@jaskarth jaskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the unit test! This looks good to me.

@jaskarth jaskarth merged commit af44be8 into Vineflower:develop/1.11.0 Dec 4, 2024
4 checks passed
@Earthcomputer Earthcomputer deleted the test_label_in_constructor branch December 4, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaskarth jaskarth jaskarth approved these changes

Assignees
No one assigned
Labels
Priority: Medium Medium priority Type: Unit Tests New or modified unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Earthcomputer @jaskarth