Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark config item mcs as a bool #443

Closed
wants to merge 1 commit into from
Closed

Conversation

Ecdcaeb
Copy link

@Ecdcaeb Ecdcaeb commented Dec 7, 2024

Mark config item mcs as a bool
Currently it lacks a type annotation and is ignored by writeOptions.

@Ecdcaeb Ecdcaeb changed the base branch from master to develop/1.11.0 December 7, 2024 04:09
@Ecdcaeb Ecdcaeb changed the base branch from develop/1.11.0 to master December 7, 2024 04:11
@jaskarth jaskarth changed the base branch from master to develop/1.11.0 December 7, 2024 16:19
@jaskarth jaskarth changed the base branch from develop/1.11.0 to master December 7, 2024 16:19
@Ecdcaeb
Copy link
Author

Ecdcaeb commented Dec 17, 2024

X.X

@Ecdcaeb Ecdcaeb closed this Dec 17, 2024
@zml2008
Copy link
Member

zml2008 commented Dec 17, 2024

hm?

@zml2008 zml2008 reopened this Dec 19, 2024
@Ecdcaeb
Copy link
Author

Ecdcaeb commented Dec 19, 2024

I got the wrong base. Is this mergable?

@zml2008
Copy link
Member

zml2008 commented Dec 21, 2024

No reason it shouldn't be with a bit of fiddling

@Ecdcaeb Ecdcaeb closed this Dec 22, 2024
@Ecdcaeb Ecdcaeb deleted the mcs-type branch December 22, 2024 06:56
@Ecdcaeb Ecdcaeb restored the mcs-type branch December 22, 2024 06:57
@Ecdcaeb Ecdcaeb deleted the mcs-type branch December 22, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants