Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements StopSound for AnimTypes and VoxelAnimTypes. #546

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Implements StopSound for AnimTypes and VoxelAnimTypes. #546

wants to merge 2 commits into from
+205 −14

Conversation

CCHyper
Copy link
Contributor

@CCHyper CCHyper commented Sep 9, 2021

Closes #474, Closes #475

This pull request implements the StopSound key from Red Alert 2 for both AnimTypes and VoxelAnimTypes.

AnimType or VoxelAnimType section.
StopSound=<VocType> - The sound effect to play when this animimation has finished/been removed. Defualts to <none>.

@CCHyper CCHyper added the new-feature New feature or request. label Sep 9, 2021
@CCHyper CCHyper added this to the RA2/YR Features milestone Sep 9, 2021
@CCHyper CCHyper requested a review from a team September 9, 2021 18:06
@github-actions
Copy link

github-actions bot commented Sep 9, 2021 •
edited
Loading

This comment is automaticly generated by Nightly.link and allows non-registered users to get download the artifacts for this pull request.

These links are also updated when the pull request is pushed to.

@CCHyper CCHyper force-pushed the develop branch 2 times, most recently from b000bdc to 3eb9620 Compare September 15, 2021 21:38
@tomsons26
Copy link
Contributor

Looking at YR it doesn't actually implement it for Voxel Anims, so this needs verifying there aren't any issues or it works at all even.
Anim code matches YR so thats good.

@CCHyper CCHyper force-pushed the develop branch 2 times, most recently from 29e7495 to 530c32e Compare October 15, 2021 21:02
@CCHyper CCHyper force-pushed the develop branch 3 times, most recently from 58dc156 to 1b504cc Compare October 16, 2021 21:59
@CCHyper CCHyper force-pushed the develop branch 2 times, most recently from eb03022 to 8ed42ec Compare January 21, 2022 22:45
@CCHyper CCHyper force-pushed the develop branch 13 times, most recently from 5e9bf4a to ee4b285 Compare February 24, 2022 01:05
@CCHyper CCHyper force-pushed the develop branch 2 times, most recently from 07c9446 to 379970b Compare November 9, 2022 14:53
@CCHyper CCHyper force-pushed the develop branch 3 times, most recently from 48cd2ea to b789478 Compare December 22, 2022 08:32
@CCHyper CCHyper force-pushed the develop branch 3 times, most recently from d649039 to 5a6cb19 Compare February 24, 2023 11:01
@CCHyper CCHyper self-assigned this Mar 28, 2023
@ZivDero ZivDero force-pushed the develop branch 2 times, most recently from 65abfa3 to 5be9542 Compare September 26, 2024 13:00
@CCHyper CCHyper removed their assignment Oct 7, 2024
@ZivDero ZivDero force-pushed the develop branch 5 times, most recently from a307ea7 to 735e008 Compare October 17, 2024 22:42
@ZivDero ZivDero force-pushed the develop branch 2 times, most recently from f40cd5a to ce12b49 Compare October 22, 2024 15:52
@ZivDero ZivDero force-pushed the develop branch 2 times, most recently from c3e7349 to 0a8e674 Compare November 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new-feature New feature or request.
Projects
None yet
Milestone
RA2/YR Features
Development

Successfully merging this pull request may close these issues.

[New Feature] Add StopSound for AnimTypes. [New Feature] Add StopSound for VoxelAnimTypes.
2 participants
@CCHyper @tomsons26