Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements OmniFire for WeaponTypes. #600

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CCHyper
Copy link
Contributor

@CCHyper CCHyper commented Sep 30, 2021

Closes #550

This pull request implements OmniFire from Red Alert 2 for WeaponTypes.

[WeaponType]
OmniFire=<boolean>
Does the unit firing this weapon have to perform a turn to face its target before firing (Only applies to UnitTypes)? Defaults to yes.

@CCHyper CCHyper added the new-feature New feature or request. label Sep 30, 2021
@CCHyper CCHyper added this to the RA2/YR Features milestone Sep 30, 2021
@CCHyper CCHyper requested a review from a team September 30, 2021 00:15
@github-actions
Copy link

github-actions bot commented Sep 30, 2021

This comment is automaticly generated by Nightly.link and allows non-registered users to get download the artifacts for this pull request.

These links are also updated when the pull request is pushed to.

@Bittah
Copy link
Collaborator

Bittah commented Oct 1, 2021

I confirmed that this works as expected the weapons of the Wolverine, Titan and Hover MLRS, but it doesn't work for the weapons of aircraft or infantry.

@CCHyper CCHyper force-pushed the develop branch 5 times, most recently from 58dc156 to 1b504cc Compare October 16, 2021 21:59
@CCHyper CCHyper force-pushed the develop branch 2 times, most recently from eb03022 to 8ed42ec Compare January 21, 2022 22:45
@CCHyper CCHyper force-pushed the develop branch 18 times, most recently from 081f201 to 4c0594c Compare February 24, 2022 01:26
@CCHyper CCHyper force-pushed the develop branch 2 times, most recently from 07c9446 to 379970b Compare November 9, 2022 14:53
@CCHyper CCHyper force-pushed the develop branch 3 times, most recently from 48cd2ea to b789478 Compare December 22, 2022 08:32
@CCHyper CCHyper force-pushed the develop branch 3 times, most recently from d649039 to 5a6cb19 Compare February 24, 2023 11:01
@CCHyper CCHyper self-assigned this Mar 28, 2023
@tomsons26
Copy link
Contributor

I confirmed that this works as expected the weapons of the Wolverine, Titan and Hover MLRS, but it doesn't work for the weapons of aircraft or infantry.

Yeah YR only has it implemented for Units, not even sure where to patch it for other types, probably a separate pr

@ZivDero ZivDero force-pushed the develop branch 2 times, most recently from 65abfa3 to 5be9542 Compare September 26, 2024 13:00
@CCHyper CCHyper removed their assignment Oct 7, 2024
@ZivDero ZivDero force-pushed the develop branch 5 times, most recently from a307ea7 to 735e008 Compare October 17, 2024 22:42
@ZivDero ZivDero force-pushed the develop branch 2 times, most recently from f40cd5a to ce12b49 Compare October 22, 2024 15:52
@ZivDero ZivDero force-pushed the develop branch 2 times, most recently from c3e7349 to 0a8e674 Compare November 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature] Add OmniFire to WeaponTypes.
3 participants