Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements naval factory and unit support. #795

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

CCHyper
Copy link
Contributor

@CCHyper CCHyper commented May 3, 2022

Closes #531

This pull request implements various features for naval factory and unit support.

NOTE: Until a VesselClass is fully implemented, The following keys will act as a separation between vessel factories and water-based UnitTypes (VesselTypes), with the aim of providing basic naval feature support.

At this time;

  • Rules: [General] -> BuildNavalYard=<BuildingType list>

    • A list of BuildingTypes that are considered a NavalYard for AI production purposes.
  • Rules: [General] -> AINavalYardAdjacency=<integer: cell distance>

    • The distance in cells the computer player can place a Naval Yard (as set by BuildNavalYard) from their Construction Yard.
  • [BuildingType] -> NavalYard=yes

    • An initial random rally point will be set at a distance of 2 cells away when the structure is placed.
    • Will allow the player to set rally points on water rather than land.
    • Allow the building to be assigned as "Primary" alongside a normal UnitType factory.
  • [UnitType] -> Naval=yes currently has no effect, but it is recommended that you define this on all water-based UnitTypes to ensure an easy transition when this feature is extended.

@CCHyper CCHyper added the new-feature New feature or request. label May 3, 2022
@CCHyper CCHyper requested a review from a team May 3, 2022 00:04
@github-actions
Copy link

github-actions bot commented May 3, 2022

This comment is automaticly generated by Nightly.link and allows non-registered users to get download the artifacts for this pull request.

These links are also updated when the pull request is pushed to.

@CCHyper CCHyper changed the title Implements initial Shipyard for BuildingTypes and Naval for TechnoTypes. Implements naval factory and unit support. May 3, 2022
@CCHyper CCHyper marked this pull request as draft May 3, 2022 12:06
@CCHyper CCHyper force-pushed the feature/initial-shipyard-naval branch 3 times, most recently from 3af0745 to 9e1d98c Compare May 3, 2022 17:41
@CCHyper CCHyper force-pushed the feature/initial-shipyard-naval branch from 9e1d98c to 94a036c Compare September 22, 2022 16:27
@CCHyper CCHyper force-pushed the develop branch 2 times, most recently from 07c9446 to 379970b Compare November 9, 2022 14:53
@CCHyper CCHyper force-pushed the develop branch 3 times, most recently from 48cd2ea to b789478 Compare December 22, 2022 08:32
@CCHyper CCHyper force-pushed the develop branch 3 times, most recently from d649039 to 5a6cb19 Compare February 24, 2023 11:01
@CCHyper CCHyper self-assigned this Mar 28, 2023
@ZivDero ZivDero force-pushed the develop branch 2 times, most recently from 65abfa3 to 5be9542 Compare September 26, 2024 13:00
@CCHyper CCHyper removed their assignment Oct 7, 2024
@ZivDero ZivDero force-pushed the develop branch 5 times, most recently from a307ea7 to 735e008 Compare October 17, 2024 22:42
@ZivDero ZivDero force-pushed the develop branch 2 times, most recently from f40cd5a to ce12b49 Compare October 22, 2024 15:52
@ZivDero ZivDero force-pushed the develop branch 2 times, most recently from c3e7349 to 0a8e674 Compare November 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature] Distinct VesselType
1 participant