-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements naval factory and unit support. #795
Draft
CCHyper
wants to merge
8
commits into
Vinifera-Developers:develop
Choose a base branch
from
CCHyper:feature/initial-shipyard-naval
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Implements naval factory and unit support. #795
CCHyper
wants to merge
8
commits into
Vinifera-Developers:develop
from
CCHyper:feature/initial-shipyard-naval
+317
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment is automaticly generated by Nightly.link and allows non-registered users to get download the artifacts for this pull request. These links are also updated when the pull request is pushed to. |
CCHyper
changed the title
Implements initial
Implements naval factory and unit support.
May 3, 2022
Shipyard
for BuildingTypes and Naval
for TechnoTypes.
CCHyper
force-pushed
the
feature/initial-shipyard-naval
branch
3 times, most recently
from
May 3, 2022 17:41
3af0745
to
9e1d98c
Compare
…nts on water rather than land.
…gned as Primary separate from normal factories.
…ching for a suitable building location.
CCHyper
force-pushed
the
feature/initial-shipyard-naval
branch
from
September 22, 2022 16:27
9e1d98c
to
94a036c
Compare
CCHyper
force-pushed
the
develop
branch
2 times, most recently
from
November 9, 2022 14:53
07c9446
to
379970b
Compare
CCHyper
force-pushed
the
develop
branch
3 times, most recently
from
December 22, 2022 08:32
48cd2ea
to
b789478
Compare
CCHyper
force-pushed
the
develop
branch
3 times, most recently
from
February 24, 2023 11:01
d649039
to
5a6cb19
Compare
ZivDero
force-pushed
the
develop
branch
2 times, most recently
from
September 26, 2024 13:00
65abfa3
to
5be9542
Compare
ZivDero
force-pushed
the
develop
branch
5 times, most recently
from
October 17, 2024 22:42
a307ea7
to
735e008
Compare
ZivDero
force-pushed
the
develop
branch
2 times, most recently
from
October 22, 2024 15:52
f40cd5a
to
ce12b49
Compare
ZivDero
force-pushed
the
develop
branch
2 times, most recently
from
November 27, 2024 12:27
c3e7349
to
0a8e674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #531
This pull request implements various features for naval factory and unit support.
NOTE: Until a VesselClass is fully implemented, The following keys will act as a separation between vessel factories and water-based UnitTypes (VesselTypes), with the aim of providing basic naval feature support.
At this time;
Rules:
[General]
->BuildNavalYard=<BuildingType list>
Rules:
[General]
->AINavalYardAdjacency=<integer: cell distance>
BuildNavalYard
) from their Construction Yard.[BuildingType]
->NavalYard=yes
[UnitType]
->Naval=yes
currently has no effect, but it is recommended that you define this on all water-based UnitTypes to ensure an easy transition when this feature is extended.