Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes various hardcoded properties from specific game-type objects. #898

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CCHyper
Copy link
Contributor

@CCHyper CCHyper commented Oct 26, 2022

Closes #554

This pull request removes various hardcoded properties of specific game-type objects. It's quite possible these properties were hardcoded during one of the original patch cycles by a programmer who did not have the access or time to modify the rules file.

The following hardcoded properties are now removed;

  • GuardRange=5 and Cost=250 from TechnoTypes GAFSDF, GAWALL, and NAWALL.
  • Explodes=yes from TechnoType E2.
  • BaseNormal=no from BuildingTypes NAFNCE and NAPOST.
  • ProneDamage=0.3 and Verses=0.4, 0.85, 0.68, 0.35, 0.35 from WarheadType ARTYHE.
  • ROF=150 and Damage=115 from WeaponType 155mm.
  • Power=17 from TiberiumType Vinifera.

@CCHyper CCHyper added the enhancement Enhancement to original behaviour. label Oct 26, 2022
@CCHyper CCHyper requested a review from a team October 26, 2022 15:46
@CCHyper CCHyper force-pushed the feature/unhardcode-types branch from feec029 to c830bbc Compare October 26, 2022 16:01
@github-actions
Copy link

github-actions bot commented Oct 26, 2022

This comment is automaticly generated by Nightly.link and allows non-registered users to get download the artifacts for this pull request.

These links are also updated when the pull request is pushed to.

@CCHyper CCHyper force-pushed the develop branch 2 times, most recently from 07c9446 to 379970b Compare November 9, 2022 14:53
@CCHyper CCHyper force-pushed the feature/unhardcode-types branch from c830bbc to 41f9d81 Compare November 24, 2022 18:05
@CCHyper CCHyper force-pushed the develop branch 3 times, most recently from 48cd2ea to b789478 Compare December 22, 2022 08:32
@CCHyper CCHyper force-pushed the feature/unhardcode-types branch from 41f9d81 to 6b2a734 Compare December 27, 2022 13:45
@CCHyper CCHyper changed the title Adds option to remove the hardcoded properties of various game-type objects. Removes various hardcoded properties from specific game-type objects. Dec 27, 2022
@CCHyper CCHyper force-pushed the feature/unhardcode-types branch from 6b2a734 to 6ae5ab5 Compare December 27, 2022 16:08
@CCHyper CCHyper force-pushed the feature/unhardcode-types branch from 6ae5ab5 to b096156 Compare February 14, 2023 00:53
@CCHyper CCHyper force-pushed the develop branch 2 times, most recently from 0edebb5 to 590971f Compare February 22, 2023 20:11
@Bittah
Copy link
Collaborator

Bittah commented Feb 22, 2023

I tried this again and since the tiberium damage was the only thing that wasn't working properly the last time, it's the only thing I tested.
Even with this new version, blue tiberium still does exactly the same amount of damage to infantry that walk over it as green tiberium.

@CCHyper CCHyper force-pushed the feature/unhardcode-types branch from b096156 to db4ad21 Compare December 26, 2023 14:27
@ZivDero ZivDero force-pushed the develop branch 2 times, most recently from 65abfa3 to 5be9542 Compare September 26, 2024 13:00
@CCHyper CCHyper removed their assignment Oct 7, 2024
@ZivDero ZivDero force-pushed the develop branch 5 times, most recently from a307ea7 to 735e008 Compare October 17, 2024 22:42
@ZivDero ZivDero force-pushed the develop branch 2 times, most recently from f40cd5a to ce12b49 Compare October 22, 2024 15:52
@ZivDero ZivDero force-pushed the develop branch 2 times, most recently from c3e7349 to 0a8e674 Compare November 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to original behaviour.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[New Feature] Hardcoded name and type checks.
2 participants