VCST-2523: Adding images to reviews #178
Annotations
11 warnings
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/ModuleConstants.cs(25,31): warning S2386: Use an immutable collection or reduce the accessibility of the public static field 'AllPermissions'. (https://rules.sonarsource.com/csharp/RSPEC-2386) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/VirtoCommerce.CustomerReviews.Core.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/ModuleConstants.cs(25,40): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/VirtoCommerce.CustomerReviews.Core.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/ModuleConstants.cs(25,40): warning S2223: Change the visibility of 'AllPermissions' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/VirtoCommerce.CustomerReviews.Core.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/ModuleConstants.cs(116,62): warning S3218: Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/VirtoCommerce.CustomerReviews.Core.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/Repositories/CustomerReviewsDbContext.cs(3,1): warning S125: Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/VirtoCommerce.CustomerReviews.Data.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/Repositories/ICustomerReviewRepository.cs(31,14): warning S4136: All 'Delete' method overloads should be adjacent. (https://rules.sonarsource.com/csharp/RSPEC-4136) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/VirtoCommerce.CustomerReviews.Data.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/Repositories/CustomerReviewRepository.cs(90,21): warning S4136: All 'Delete' method overloads should be adjacent. (https://rules.sonarsource.com/csharp/RSPEC-4136) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/VirtoCommerce.CustomerReviews.Data.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.ExperienceApi/Commands/CreateReviewCommandHandler.cs(102,25): warning S1067: Reduce the number of conditional operators (4) used in the expression (maximum allowed 3). (https://rules.sonarsource.com/csharp/RSPEC-1067) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.ExperienceApi/VirtoCommerce.CustomerReviews.ExperienceApi.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/Services/WilsonRatingCalculator.cs(32,13): warning S121: Add curly braces around the nested statement(s) in this 'if' block. (https://rules.sonarsource.com/csharp/RSPEC-121) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/VirtoCommerce.CustomerReviews.Data.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/BackgroundJobs/RequestCustomerReviewJob.cs(37,40): warning S107: Constructor has 9 parameters, which is greater than the 7 authorized. (https://rules.sonarsource.com/csharp/RSPEC-107) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/VirtoCommerce.CustomerReviews.Data.csproj]
|
Get Changelog
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Loading