Update platform #112
Annotations
3 errors and 10 warnings
Publish Manifest
Cloning into '/home/runner/work/vc-module-customer-review/vc-module-customer-review/artifacts/vc-modules'...
|
|
Publish Manifest
92be6014..54753cb8 HEAD -> master
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/ModuleConstants.cs(18,31): warning S2386: Use an immutable collection or reduce the accessibility of the public static field 'AllPermissions'. (https://rules.sonarsource.com/csharp/RSPEC-2386) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/VirtoCommerce.CustomerReviews.Core.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/ModuleConstants.cs(18,40): warning S1104: Make this field 'private' and encapsulate it in a 'public' property. (https://rules.sonarsource.com/csharp/RSPEC-1104) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/VirtoCommerce.CustomerReviews.Core.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/ModuleConstants.cs(18,40): warning S2223: Change the visibility of 'AllPermissions' or make it 'const' or 'readonly'. (https://rules.sonarsource.com/csharp/RSPEC-2223) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/VirtoCommerce.CustomerReviews.Core.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/ModuleConstants.cs(101,62): warning S3218: Rename this property to not shadow the outer class' member with the same name. (https://rules.sonarsource.com/csharp/RSPEC-3218) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Core/VirtoCommerce.CustomerReviews.Core.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.ExperienceApi/Middleware/EvalVendorRatingMiddleware.cs(23,31): warning S4457: Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.ExperienceApi/VirtoCommerce.CustomerReviews.ExperienceApi.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.ExperienceApi/Middleware/EvalProductVendorRatingMiddleware.cs(27,31): warning S4457: Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.ExperienceApi/VirtoCommerce.CustomerReviews.ExperienceApi.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/Repositories/ICustomerReviewRepository.cs(30,14): warning S4136: All 'Delete' method overloads should be adjacent. (https://rules.sonarsource.com/csharp/RSPEC-4136) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/VirtoCommerce.CustomerReviews.Data.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/Repositories/CustomerReviewRepository.cs(103,21): warning S4136: All 'Delete' method overloads should be adjacent. (https://rules.sonarsource.com/csharp/RSPEC-4136) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/VirtoCommerce.CustomerReviews.Data.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/Services/WilsonRatingCalculator.cs(32,13): warning S121: Add curly braces around the nested statement(s) in this 'if' block. (https://rules.sonarsource.com/csharp/RSPEC-121) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/VirtoCommerce.CustomerReviews.Data.csproj]
|
Build
/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/BackgroundJobs/RequestCustomerReviewJob.cs(37,40): warning S107: Constructor has 9 parameters, which is greater than the 7 authorized. (https://rules.sonarsource.com/csharp/RSPEC-107) [/home/runner/work/vc-module-customer-review/vc-module-customer-review/src/VirtoCommerce.CustomerReviews.Data/VirtoCommerce.CustomerReviews.Data.csproj]
|
The logs for this run have expired and are no longer available.
Loading