Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCST-1924: Add validation to the process of adding a review #64

Merged
merged 21 commits into from
Oct 24, 2024

Conversation

Ljutyj
Copy link
Contributor

@Ljutyj Ljutyj commented Oct 4, 2024

Description

fix: the title filed has been made optional in the createCustomerReview mutation. Fixed of some fields requirements in DB.

feat: A new mutation "createReview" has been added for creating reviews. This mutation uses validation of the UserName, EntityName, and Review text fields so that they are not empty. Also added validation of the Rating field so that it falls into the range from 1 to 5 and validation that the user has not yet left a review for this product. At the end added verification that the product was purchased by the user. A query "canLeaveFeedback" has been added to find out if it is possible for the user to add a review to the product. Authentication for all actions (except customerReviews query) also has been added.

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-1924

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.CustomerReviews_3.807.0-pr-64-0c9a.zip

Ljutyj added 3 commits October 2, 2024 15:59
fix: the title filed has been made optional in the createCustomerReview mutation
feat: Validation of the UserName, EntityName, and Review text fields has been added so that they are not empty. Added validation of the Rating field so that it falls into the range from 1 to 5. Added validation that the user has not yet left a review for this product.
feat: Added verification that the product was purchased by the user
@Ljutyj Ljutyj requested review from OlegoO and artem-dudarev October 4, 2024 15:14
artem-dudarev
artem-dudarev previously approved these changes Oct 16, 2024
artem-dudarev
artem-dudarev previously approved these changes Oct 16, 2024
Copy link

@artem-dudarev artem-dudarev changed the title VCST-1924: Added validation to the process of adding a review VCST-1924: Add validation to the process of adding a review Oct 24, 2024
@Ljutyj Ljutyj merged commit a35f8fe into dev Oct 24, 2024
5 checks passed
@Ljutyj Ljutyj deleted the feat/VCST-1924 branch October 24, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants