-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VCST-1924: Add validation to the process of adding a review #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: the title filed has been made optional in the createCustomerReview mutation
feat: Validation of the UserName, EntityName, and Review text fields has been added so that they are not empty. Added validation of the Rating field so that it falls into the range from 1 to 5. Added validation that the user has not yet left a review for this product.
feat: Added verification that the product was purchased by the user
feat: A request canLeaveFeedback has been added to find out if it is possible for the user to add a review to the product
…module. Renaming classes. Review only for Products.
fix: Fixed of some fields requirements feat: A new mutation and a scheme for creating reviews. Authorization for all actions.
artem-dudarev
previously approved these changes
Oct 16, 2024
This reverts commit 4cc4ee3.
artem-dudarev
previously approved these changes
Oct 16, 2024
Quality Gate passedIssues Measures |
artem-dudarev
approved these changes
Oct 24, 2024
artem-dudarev
changed the title
VCST-1924: Added validation to the process of adding a review
VCST-1924: Add validation to the process of adding a review
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: the title filed has been made optional in the createCustomerReview mutation. Fixed of some fields requirements in DB.
feat: A new mutation "createReview" has been added for creating reviews. This mutation uses validation of the UserName, EntityName, and Review text fields so that they are not empty. Also added validation of the Rating field so that it falls into the range from 1 to 5 and validation that the user has not yet left a review for this product. At the end added verification that the product was purchased by the user. A query "canLeaveFeedback" has been added to find out if it is possible for the user to add a review to the product. Authentication for all actions (except customerReviews query) also has been added.
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-1924
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.CustomerReviews_3.807.0-pr-64-0c9a.zip