Skip to content

Commit

Permalink
VCST-2482: Fix value cannot be null. (Parameter 'element') at System.…
Browse files Browse the repository at this point in the history
…ArgumentNullException (#87)
  • Loading branch information
OlegoO authored Dec 26, 2024
1 parent e09868d commit 5d9ee77
Show file tree
Hide file tree
Showing 9 changed files with 301 additions and 292 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
<SonarQubeTestProject>false</SonarQubeTestProject>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="CsvHelper" Version="30.0.1" />
<PackageReference Include="VirtoCommerce.Platform.Core" Version="3.800.0" />
<PackageReference Include="VirtoCommerce.PricingModule.Core" Version="3.800.0" />
<PackageReference Include="VirtoCommerce.PricingModule.Data" Version="3.800.0" />
<PackageReference Include="CsvHelper" Version="33.0.1" />
<PackageReference Include="VirtoCommerce.Platform.Core" Version="3.853.0" />
<PackageReference Include="VirtoCommerce.PricingModule.Core" Version="3.809.0" />
<PackageReference Include="VirtoCommerce.PricingModule.Data" Version="3.809.0" />
</ItemGroup>
<ItemGroup>
<Folder Include="Events\" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public CsvPriceImportReporter(string reportFilePath, IBlobStorageProvider blobSt

public async Task WriteAsync(ImportError error)
{
using (await AsyncLock.GetLockByKey(_reportFilePath).GetReleaserAsync())
using (await AsyncLock.GetLockByKey(_reportFilePath).LockAsync())
{
ReportIsNotEmpty = true;
await _streamWriter.WriteLineAsync(GetLine(error));
Expand All @@ -55,7 +55,7 @@ public void WriteHeader(string header)

public async ValueTask DisposeAsync()
{
using (await AsyncLock.GetLockByKey(_reportFilePath).GetReleaserAsync())
using (await AsyncLock.GetLockByKey(_reportFilePath).LockAsync())
{
await _streamWriter.DisposeAsync();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
<Folder Include="Repositories\" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="CsvHelper" Version="30.0.1" />
<PackageReference Include="FluentValidation" Version="11.8.1" />
<PackageReference Include="VirtoCommerce.AssetsModule.Core" Version="3.800.0" />
<PackageReference Include="VirtoCommerce.CatalogModule.Core" Version="3.800.0" />
<PackageReference Include="VirtoCommerce.PricingModule.Core" Version="3.800.0" />
<PackageReference Include="VirtoCommerce.Platform.Data" Version="3.800.0" />
<PackageReference Include="VirtoCommerce.Platform.Hangfire" Version="3.800.0" />
<PackageReference Include="CsvHelper" Version="33.0.1" />
<PackageReference Include="FluentValidation" Version="11.10.0" />
<PackageReference Include="VirtoCommerce.AssetsModule.Core" Version="3.808.0" />
<PackageReference Include="VirtoCommerce.CatalogModule.Core" Version="3.822.0" />
<PackageReference Include="VirtoCommerce.PricingModule.Core" Version="3.809.0" />
<PackageReference Include="VirtoCommerce.Platform.Data" Version="3.853.0" />
<PackageReference Include="VirtoCommerce.Platform.Hangfire" Version="3.853.0" />
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ angular.module('virtoCommerce.priceExportImportModule')
importResources.preview({ filePath: blade.csvFilePath}, (data) => {
blade.currentEntities = data.results;
blade.totalCount = data.totalCount;
$scope.pageSettings.totalItems = 10;
$scope.pageSettings.totalItems = Math.min(10, blade.totalCount);
getInvalidRowsCount();
blade.isLoading = false;
}, (error) => { bladeNavigationService.setError('Error ' + error.status, blade); });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,12 @@ angular.module('virtoCommerce.priceExportImportModule')
);
}

bladeNavigationService.closeBlade(blade);
if (blade.notification.finished) {
bladeNavigationService.closeChildrenBlades(blade.parentBlade.parentBlade.parentBlade, function () { });
}
else {
bladeNavigationService.closeBlade(blade);
}
}

}]);
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@
<ItemGroup>
<ProjectReference Include="..\VirtoCommerce.PriceExportImportModule.Data\VirtoCommerce.PriceExportImportModule.Data.csproj" />
</ItemGroup>
<ItemGroup>
<None Update="module.manifest">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
</ItemGroup>
<ItemGroup>
<Folder Include="Controllers\Api\" />
<Folder Include="Scripts\blades\" />
Expand Down
8 changes: 4 additions & 4 deletions src/VirtoCommerce.PriceExportImportModule.Web/module.manifest
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
<version>3.802.0</version>
<version-tag />

<platformVersion>3.800.0</platformVersion>
<platformVersion>3.853.0</platformVersion>
<dependencies>
<dependency id="VirtoCommerce.Pricing" version="3.800.0" />
<dependency id="VirtoCommerce.Catalog" version="3.800.0" />
<dependency id="VirtoCommerce.Assets" version="3.808.0" />
<dependency id="VirtoCommerce.Catalog" version="3.822.0" />
<dependency id="VirtoCommerce.Export" version="3.800.0" />
<dependency id="VirtoCommerce.Assets" version="3.800.0" />
<dependency id="VirtoCommerce.Pricing" version="3.809.0" />
</dependencies>

<title>Price Export Import</title>
Expand Down
Loading

0 comments on commit 5d9ee77

Please sign in to comment.