-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make participant.joined
and participant.left
retry logic into a background function
#20
Conversation
2cf8ce7
to
2791f52
Compare
Hm, actually I'm a bit confused why the call to the background function isn't returning immediately
I feel like the It's weird because it does say So this current code as it stands could still be blocking 🤔 |
2791f52
to
ad548db
Compare
ad548db
to
341977b
Compare
Oh nevermind. We good 👍 I put a long timeout in the background function to test it and got it to print in the expected order
|
Use env value instead
Make
participant.joined
andparticipant.left
retry logic into a background functionFixes #15
This change makes it so we fire off a request to the participant joined/left retry logic in a background function then return immediately to zoom so zoom doesn't send a retry request
Currently, we perform retry logic within the initial zoom request, which is ostensibly causing zoom to time out
This PR is a WIP
Glaring TODO
Don't hardcode my local URL as
APP_HOST
https://github.com/Virtual-Coffee/webhooks/pull/20/files#diff-fd3a3971ff32072dc258467648a607790c47e180b8b82e0b426b53c9ea9d8afeR101