Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed by in connected_neuron_by_type #194

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

dosumis
Copy link
Member

@dosumis dosumis commented Sep 4, 2024

  • Bug fix
  • Method also now deals more gracefully with empty results lists
  • Updated doc
  • weight now back to ARG from KWARG so uses built-in warnings
  • Added tests
  • Added IDs to returned dataframe and rearranged columns

Method also now deals more gracefully with empty results lists
@dosumis dosumis requested a review from Robbie1977 September 4, 2024 10:47
@dosumis
Copy link
Member Author

dosumis commented Sep 4, 2024

@Robbie1977 - hard to tell what this is failing on.

Doesn't look like fail is on edited method and its tests, but hard to tell.
https://github.com/VirtualFlyBrain/VFB_connect/actions/runs/10700434740/job/29664168967?pr=194

Can you run tests locally?

@dosumis
Copy link
Member Author

dosumis commented Sep 4, 2024

OK. That seems to have fixed everything. OK to merge?

@Robbie1977 Robbie1977 merged commit b3b42dd into master Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants