All tests should now work as intended, even if the field to update in…

… Idylis is originally empty before update
VirtuoWorks · Sep 15, 2021 · 38863d2 · 38863d2
1 parent 6b50cf6
commit 38863d2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/IdylisAPI/index.spec.ts b/src/IdylisAPI/index.spec.ts
@@ -91,7 +91,7 @@ describe('The IdyliAPI class', () => {
           0,
           'REFTVADISTINCT',
           [{'COMPTEVENTETVA': `${compteAchatTest}`}],
-          '7',
+          '2',
       );
 
       expect(receivedValue)

diff --git a/src/IdylisAPI/index.ts b/src/IdylisAPI/index.ts
@@ -482,7 +482,7 @@ export default class IdylisAPI {
               const originValue: string[] = Object.values(keyToCheck);
               const updatedValue: string[] = Object.values(table);
 
-              if (typeguards.isCdata(keyToCheck) && keyToCheck?.__cdata !== '') {
+              if (typeguards.isCdata(keyToCheck)) {
                 if (String(originValue) !== String(updatedValue)) {
                   majTableJson[docType].FICHE[String(keyToUpdate)] = `<![CDATA[${Object.values({__cdata: String(updatedValue)})}]]]]><![CDATA[>`;
                   jsonDocumentFicheToUpdate[String(keyToUpdate)] = {__cdata: String(updatedValue)};
@@ -579,7 +579,7 @@ export default class IdylisAPI {
                         const originValue: string[] = Object.values(keyToCheck);
                         const updatedValue: string[] = Object.values(table);
 
-                        if (typeguards.isCdata(keyToCheck) && keyToCheck?.__cdata !== '') {
+                        if (typeguards.isCdata(keyToCheck)) {
                           if (String(originValue) === String(updatedValue)) {
                             updateConfirmation = true;
                           } else {
@@ -610,6 +610,7 @@ export default class IdylisAPI {
           };
         } else {
           /* istanbul ignore next */
+          console.log('primarykey is not a string');
           updateConfirmation = false;
         };
       } else {

diff --git a/src/typeguards/index.ts b/src/typeguards/index.ts
@@ -31,7 +31,7 @@ export class Typeguards {
    * is the one expected
    */
   isPrimaryKeyValue(
-      primaryKeyValue: string | void,
+      primaryKeyValue: string | undefined,
   ): primaryKeyValue is string {
     return !!primaryKeyValue;
   };