Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deprecation warnings for commas with whitespace used as using directive value separators #3366

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

Gedochao
Copy link
Contributor

Bumps using_directives to 1.1.3.
https://github.com/VirtusLab/using_directives/releases/tag/v1.1.3

The main improvement happens in:

Given:

//> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
println("Deprecation warnings should have been printed")

Before:

[warn] ./example.sc:1:19
[warn] Use of commas as separators is deprecated. Only whitespace is neccessary.
[warn] //> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
[warn]                   ^
[warn] ./example.sc:1:26
[warn] Use of commas as separators is deprecated. Only whitespace is neccessary.
[warn] //> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
[warn]                          ^
[warn] ./example.sc:1:28
[warn] Use of commas as separators is deprecated. Only whitespace is neccessary.
[warn] //> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
[warn]                            ^
[warn] ./example.sc:1:52
[warn] Use of commas as separators is deprecated. Only whitespace is neccessary.
[warn] //> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
[warn] 

After:

[warn] ./example.sc:1:26
[warn] Use of commas as separators is deprecated. Only whitespace is neccessary.
[warn] //> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
[warn]                          ^
[warn] ./example.sc:1:52
[warn] Use of commas as separators is deprecated. Only whitespace is neccessary.
[warn] //> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
[warn]                                                    ^

@Gedochao Gedochao merged commit 5b481bd into VirtusLab:main Dec 12, 2024
74 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants