Recover from invalid paths returned from Bloop diagnostics #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
force-pushed
the
maintenance/recover-from-invalid-paths-from-bloop-diagnostic
branch
from
ca725c3 to
fa98948
Compare
Gedochao
force-pushed
the
maintenance/recover-from-invalid-paths-from-bloop-diagnostic
branch
from
fa98948 to
82fdad2
Compare
tgodzik
approved these changes
Dec 16, 2024
|
Actually, wouldn't the main error lie in the compiler itself? Bloop just forwards what it gets, it doesn't change paths |
@tgodzik I'd say it would if it wasn't for the fact that the problem doesn't occur with
No idea whatsoever. Would have to debug in Bloop, probably. |
|
But the invalid path is generated in the compiler. It's just not validated since we use rendered message. |
Gedochao
deleted the
maintenance/recover-from-invalid-paths-from-bloop-diagnostic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3370
This is sort of a band-aid, as we still might require a fix upstream in Bloop. (cc @tgodzik)
It seems we're getting an invalid path in a diagnostic coming from Bloop.
Refer to
scala-cli/modules/build/src/main/scala/scala/build/ConsoleBloopBuildClient.scala
Line 81 in 60f7322
I just make sure we recover from it in the CLI.