Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Resolved Image Display Issue #1949

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

Anas-Rehberlik
Copy link
Contributor

@Anas-Rehberlik Anas-Rehberlik commented Sep 21, 2023

Related Issue

  • Fixed issues with project images and links.

Closes: #1946

Describe the changes you've made

In this pull request, I addressed the following issues:

  1. Image Path Correction:

    • Corrected the image paths in the project configuration to ensure all project images are displayed correctly on the Home/Project page.
  2. Renaming Image File:

    • Renamed the image file 'Insect Catch.png' to 'Insect-Catch.png' to resolve the issue of the image not being displayed due to incorrect file naming.
  3. Fixing Duplicate Projects:

    • Updated the HTML path of one of the projects named 'Random_Picker_visualiser' to resolve the issue of duplicate projects with the same details.
  4. GIF Link Fix:

    • Added and linked 'Random_Picker_Visualiser.gif' to show project image on Home/Project page for another Random_Picker_visualiser Project"

Describe if there is any unusual behavior of your code

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • New and existing unit tests pass locally with my changes.

Screenshots and GIF

Screenshots and GIF are showcasing the changes for your reference.

javascript-projects
Now all project images are visible on Home/Projects

image
Now image of 'Insect-Catch Project' is also visible by Renaming the image file 'Insect Catch.png' to 'Insect-Catch.png'.

Random_Picker_Visualiser
Previously both project show same html file that's why updated the html path of one of the project and also added gif and png image file to show images of the projects on Home/Projects Page.

@Vishal-raj-1 Vishal-raj-1 merged commit d5450ab into Vishal-raj-1:main Sep 28, 2023
@github-actions
Copy link

Thank you @Anas-Rehberlik for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects Images are not shown
2 participants