feat: add preference to disable editor cursor animation

Visual-Code-Space · Dec 12, 2024 · b9f8d58 · b9f8d58
1 parent 27681db
commit b9f8d58
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 0 deletions.
diff --git a/core/app/src/main/java/com/itsaky/androidide/preferences/editorPrefExts.kt b/core/app/src/main/java/com/itsaky/androidide/preferences/editorPrefExts.kt
@@ -42,6 +42,7 @@ import com.itsaky.androidide.preferences.internal.EditorPreferences.USE_CUSTOM_F
 import com.itsaky.androidide.preferences.internal.EditorPreferences.USE_ICU
 import com.itsaky.androidide.preferences.internal.EditorPreferences.USE_MAGNIFER
 import com.itsaky.androidide.preferences.internal.EditorPreferences.USE_SOFT_TAB
+import com.itsaky.androidide.preferences.internal.EditorPreferences.CURSOR_ANIMATION_ENABLED
 import com.itsaky.androidide.preferences.internal.EditorPreferences.WORD_WRAP
 import com.itsaky.androidide.resources.R.drawable
 import com.itsaky.androidide.resources.R.string
@@ -86,6 +87,7 @@ private class CommonConfigurations(
     addPreference(VisibiblePasswordFlag())
     addPreference(DeleteEmptyLines())
     addPreference(DeleteTabs())
+    addPreference(CursorAnimationEnabled())
     addPreference(StickyScrollEnabled())
     addPreference(PinLineNumbersEnabled())
     addPreference(CompletionsMatchLower())
@@ -147,6 +149,16 @@ private class UseSoftTab(
 ) : SwitchPreference(setValue = EditorPreferences::useSoftTab::set,
   getValue = EditorPreferences::useSoftTab::get)
 
+@Parcelize
+private class CursorAnimationEnabled(
+  override val key: String = CURSOR_ANIMATION_ENABLED,
+  override val title: Int = string.idepref_editor_cursorAnimationEnabled_title,
+  override val summary: Int? = string.idepref_editor_cursorAnimationEnabled_summary,
+  override val icon: Int? = drawable.ic_space, // TODO: Add a icon 
+) : SwitchPreference(setValue = EditorPreferences::cursorAnimationEnabled::set,
+  getValue = EditorPreferences::cursorAnimationEnabled::get)
+
+
 @Parcelize
 private class TabSize(
   override val key: String = TAB_SIZE,

diff --git a/core/app/src/main/java/com/itsaky/androidide/ui/CodeEditorView.kt b/core/app/src/main/java/com/itsaky/androidide/ui/CodeEditorView.kt
@@ -341,6 +341,7 @@ class CodeEditorView(
     onUseIcuPrefChanged()
     onDeleteEmptyLinesPrefChanged()
     onDeleteTabsPrefChanged()
+    onCursorAnimationPrefChanged()
     onStickyScrollEnabeldPrefChanged()
     onPinLineNumbersPrefChanged()
   }
@@ -409,6 +410,10 @@ class CodeEditorView(
     binding.editor.props.deleteMultiSpaces = if (EditorPreferences.deleteTabsOnBackspace) -1 else 1
   }
 
+  private fun onCursorAnimationPrefChanged() {
+    binding.editor.cursorAnimationEnabled = EditorPreferences.cursorAnimationEnabled
+  }
+
   private fun onStickyScrollEnabeldPrefChanged() {
     binding.editor.props.stickyScroll = EditorPreferences.stickyScrollEnabled
   }
@@ -460,6 +465,7 @@ class CodeEditorView(
       EditorPreferences.USE_MAGNIFER -> onMagnifierPrefChanged()
       EditorPreferences.USE_ICU -> onUseIcuPrefChanged()
       EditorPreferences.USE_CUSTOM_FONT -> onCustomFontPrefChanged()
+      EditorPreferences.CURSOR_ANIMATION_ENABLED -> onCursorAnimationPrefChanged()
       EditorPreferences.DELETE_EMPTY_LINES -> onDeleteEmptyLinesPrefChanged()
       EditorPreferences.DELETE_TABS_ON_BACKSPACE -> onDeleteTabsPrefChanged()
       EditorPreferences.STICKY_SCROLL_ENABLED -> onStickyScrollEnabeldPrefChanged()

diff --git a/core/resources/src/main/res/values/strings.xml b/core/resources/src/main/res/values/strings.xml
@@ -258,6 +258,8 @@
   <string name="msg_swipe_for_output">Swipe up for @@build output@@.</string>
   <string name="idepref_editor_useSoftTabs_title">Use soft tab</string>
   <string name="idepref_editor_useSoftTabs_summary">Choose whether to use spaces instead of tab character (\\t).</string>
+  <string name="idepref_editor_cursorAnimationEnabled_title">Enable cursor animation</string>
+  <string name="idepref_editor_cursorAnimationEnabled_summary">Choose whether to use animation when moving the cursor.</string>
   <string name="btn_donate">Donate</string>
   <string name="btn_docs">Documentation</string>
   <string name="btn_close">Close</string>

diff --git a/...preferences/src/main/java/com/itsaky/androidide/preferences/internal/EditorPreferences.kt b/...preferences/src/main/java/com/itsaky/androidide/preferences/internal/EditorPreferences.kt
@@ -43,6 +43,7 @@ object EditorPreferences {
   const val USE_ICU = "idepref_editor_useIcu"
   const val USE_SOFT_TAB = "idepref_editor_useSoftTab"
   const val USE_CUSTOM_FONT = "idepref_editor_useCustomFont"
+  const val CURSOR_ANIMATION_ENABLED = "idepref_editor_cursorAnimationEnabled"
   const val DELETE_EMPTY_LINES = "idepref_editor_deleteEmptyLines"
   const val DELETE_TABS_ON_BACKSPACE = "idepref_editor_deleteTab"
   const val STICKY_SCROLL_ENABLED = "idepref_editor_stickyScrollEnabled"
@@ -147,6 +148,12 @@ object EditorPreferences {
       prefManager.putBoolean(USE_CUSTOM_FONT, value)
     }
 
+  var cursorAnimationEnabled: Boolean
+    get() = prefManager.getBoolean(CURSOR_ANIMATION_ENABLED, false)
+    set(value) {
+      prefManager.putBoolean(CURSOR_ANIMATION_ENABLED, value)
+    }
+
   var colorScheme: String
     get() = prefManager.getString(COLOR_SCHEME, DEFAULT_COLOR_SCHEME)
     set(value) {