Feature/api/mrxn23 97 delete cost surface [MRXN23-97] #1529
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Part of the GET endpoints functionality is in this PR, as it was shared on the CostSurfaceService. Thought it was not worth the hassle to rearrange everything, when the GETs PR is going to be merged on top of this one too. |
KevSanchez
changed the base branch from
develop
to
chore/cost-surfaces-data-migration
KevSanchez
changed the base branch from
chore/cost-surfaces-data-migration
to
feature/api/cost-surface-migrations
KevSanchez
force-pushed
the
feature/api/MRXN23-97-delete-cost-surface
branch
from
3d65805 to
2823402
Compare
| if (piece === ClonePiece.ScenarioInputFolder) { | ||
| this.logger.log('SCENARIO INPUT FOLDER'); | ||
| } |
There was a problem hiding this comment.
just a question: I'm almost always in favour (actually fanatical) about meaningful logging that could help when inspecting live systems, but I'm not sure about this - why do we add info logging for this specifically? and what is this log line meant to convey?
There was a problem hiding this comment.
Oops, sorry about this one. This was part of the process of deciphering the whole cloning mystery. Seems like it slipped away.
api/apps/api/src/modules/cost-surface/delete-cost-surface/delete-cost-surface.handler.spec.ts
Show resolved
Hide resolved
…faces for a Project
KevSanchez
force-pushed
the
feature/api/MRXN23-97-delete-cost-surface
branch
from
7c02932 to
e1c2fac
Compare
Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md)