use cost-surfaces as part of path for cost surface-related endpoints (rather than cost-surface) [MRXN23-479] [MRXN23-480]
#1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hotzevzl
force-pushed
the
chore/api/MRXN23-479_update-paths-of-cost-surface-endpoints-to-match-conventions
branch
from
a347b35 to
2e58a58
Compare
hotzevzl
force-pushed
the
chore/api/MRXN23-479_update-paths-of-cost-surface-endpoints-to-match-conventions
branch
from
73bd0e9 to
3a43199
Compare
yulia-bel
reviewed
Oct 9, 2023
| @Req() req: RequestWithAuthenticatedUser, | ||
| @Body() dto: UploadShapefileDto, | ||
| ): Promise<JsonApiAsyncJobMeta> { | ||
| const outcome = await this.projectsService.addProtectedAreaFor( |
There was a problem hiding this comment.
just a question/suggestion - maybe move the addProtedtedAreaFor() to ProjectProtectedAreasService.. its basically just doing the file validation and acl though and then passes to AddProtectedAreaService, so maybe not worth it.. but being inspired by this nice cleanup, feels a bit like there are too much services involved in project protected areas
There was a problem hiding this comment.
yep, it does make sense, but then we enter the rabbit hole of cleaning up ProjectsService which is another sprawling chaos, and... I'd rather stop at the controller layer for this PR 😬
yulia-bel
approved these changes
Oct 9, 2023
hotzevzl
changed the title
cost-surfaces as part of path for cost surface-related endpoints (rather than cost-surface) [MRXN23-479]cost-surfaces as part of path for cost surface-related endpoints (rather than cost-surface) [MRXN23-479] [MRXN23-480]
…d OpenAPI category
…and OpenAPI category
…nd OpenAPI category
…er and OpenAPI category
…roller and OpenAPI category
…n their own controller and OpenAPI category
…troller and OpenAPI category
hotzevzl
force-pushed
the
chore/api/MRXN23-479_update-paths-of-cost-surface-endpoints-to-match-conventions
branch
from
3a43199 to
905d98f
Compare
This was long overdue - I should have done this while splitting the sprawling blob of monolithing e2e runs into subsets, but well, better now than never. Project-related tests within API e2e tests were among the longest-running, and the split by concern in this commit should make each subset more manageable (for example, leading to shorter run times if needing to trigger a new run of a subset manually because of spurious failures in CI).
hotzevzl
force-pushed
the
chore/api/MRXN23-479_update-paths-of-cost-surface-endpoints-to-match-conventions
branch
from
905d98f to
c8dd035
Compare
hotzevzl
deleted the
chore/api/MRXN23-479_update-paths-of-cost-surface-endpoints-to-match-conventions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://vizzuality.atlassian.net/browse/MRXN23-479