Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds upcoming changes banner to homepage (cherry-picked change for MaPP v1 production environment) [MRXN23-560] #1632

Merged

Conversation

hotzevzl
Copy link
Member

Substitute this line for a meaningful title for your changes

Overview

Adds notice banner for upcoming changes, for MaPP v1 (currently only used in the TNC production environment)

Designs

N/A

Testing instructions

Banner should be shown in production when enabled via feature flag. Nothing else should break 🙏🏼 .

Feature relevant tickets

https://vizzuality.atlassian.net/browse/MRXN23-560


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@hotzevzl hotzevzl requested a review from agnlez January 18, 2024 15:47
Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
marxan ❌ Failed (Inspect) Jan 18, 2024 3:47pm

@hotzevzl hotzevzl changed the title adds upcoming changes banner to homepage (cherry-picked change for MaPP v1 production environment) adds upcoming changes banner to homepage (cherry-picked change for MaPP v1 production environment) [MRXN23-560] Jan 18, 2024
@hotzevzl
Copy link
Member Author

@andresgnlez this is what I think we need in order to add the notice banner for the upcoming MaPP release to the production instance - could you please cross-check that I didn't do anytyhing silly here?

The vercel deploy triggered as part of this PR's actions is failing because we are feeding the Vercel build the old and obsolete Node version from our package.json - though this should not be a problem in production as we just keep running what we have there in terms of Node runtime version.

@agnlez
Copy link
Member

agnlez commented Jan 18, 2024

@hotzevzl yes, this is perfect, thanks Andrea!

And yes, I received the fail notification from Vercel, we should probably shut down that instance as it is not being used, AFAIK, but that's a battle for another day :D

@hotzevzl hotzevzl changed the base branch from develop to main January 18, 2024 16:53
@hotzevzl hotzevzl merged commit 1a60c47 into main Jan 18, 2024
12 of 13 checks passed
@hotzevzl hotzevzl deleted the chore/app/MRXN23-560_add-banner-to-mapp-v1-production branch January 18, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants