Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] fixs point defense registering #367

Closed
wants to merge 2 commits into from
Closed

Conversation

VoRe-bot
Copy link

@VoRe-bot VoRe-bot commented Sep 4, 2024

Original PR: Citadel-Station-13/Citadel-Station-13-RP#6727

About The Pull Request

allows point defense control to be properly registered by checking if the new indent is taken, instead of the current tag. also makes sure that the batteries themselves dont check for id taged controllers with their own tag???? idk why that was a thing. im guessing copy paste.

Why It's Good For The Game

fixes bug where both were unregisterable.

Changelog

🆑
fix: point defense control now can be set.
fix: point defense battery can be set to a new ident tag.
/:cl:

Niezann and others added 2 commits September 4, 2024 10:34
## About The Pull Request

allows point defense control to be properly registered by checking if
the new indent is taken, instead of the current tag. also makes sure
that the batteries themselves dont check for id taged controllers with
their own tag???? idk why that was a thing. im guessing copy paste.

## Why It's Good For The Game

fixes bug where both were unregisterable.

## Changelog

:cl:
fix: point defense control now can be set.
fix: point defense battery can be set to a new ident tag.
/:cl:
Copy link

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ two week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Sep 19, 2024
Copy link

github-actions bot commented Oct 3, 2024

This PR was closed due to inactivity, if you feel this was done in error, please request a maintainer remove the stale label on your PR, to reset the stale timer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants