tests: flaky tests fixes (#6098) #6
reviewdog [Lint Warnings] report
reported by reviewdog 🐶
Findings (12)
crypto/stateproof/verifier.go|101 col 4| G601: Implicit memory aliasing in for loop. (gosec)
ledger/store/trackerdb/generickv/migrations.go|169 col 23| G601: Implicit memory aliasing in for loop. (gosec)
ledger/store/trackerdb/sqlitedriver/schema.go|790 col 55| G601: Implicit memory aliasing in for loop. (gosec)
ledger/store/trackerdb/sqlitedriver/schema.go|799 col 52| G601: Implicit memory aliasing in for loop. (gosec)
ledger/acctdeltas.go|134 col 83| G601: Implicit memory aliasing in for loop. (gosec)
ledger/store/trackerdb/generickv/schema.go|136 col 6| func creatableMaxRangePrefix is unused (unused)
ledger/store/trackerdb/sqlitedriver/spVerificationAccessor.go|38 col 6| type stateProofVerificationReaderWriter is unused (unused)
ledger/store/trackerdb/sqlitedriver/spVerificationAccessor.go|51 col 6| func makeStateProofVerificationReaderWriter is unused (unused)
data/transactions/verify/txn.go|84 col 5| var errTxGroupInsuffientLsigBudget is unused (unused)
tools/debug/transplanter/main.go|158 col 6| type headerDecoder is unused (unused)
tools/debug/transplanter/main.go|162 col 6| type decoderV1 is unused (unused)
tools/debug/transplanter/main.go|164 col 18| func decoderV1.decodeHeader is unused (unused)
Filtered Findings (0)
Annotations
Check failure on line 101 in crypto/stateproof/verifier.go
github-actions / Lint Warnings
[Lint Warnings] crypto/stateproof/verifier.go#L101
G601: Implicit memory aliasing in for loop. (gosec)
Raw output
crypto/stateproof/verifier.go:101:4: G601: Implicit memory aliasing in for loop. (gosec)
&r.SigSlot.Sig,
^
Check failure on line 169 in ledger/store/trackerdb/generickv/migrations.go
github-actions / Lint Warnings
[Lint Warnings] ledger/store/trackerdb/generickv/migrations.go#L169
G601: Implicit memory aliasing in for loop. (gosec)
Raw output
ledger/store/trackerdb/generickv/migrations.go:169:23: G601: Implicit memory aliasing in for loop. (gosec)
bad.SetAccountData(&account)
^
Check failure on line 790 in ledger/store/trackerdb/sqlitedriver/schema.go
github-actions / Lint Warnings
[Lint Warnings] ledger/store/trackerdb/sqlitedriver/schema.go#L790
G601: Implicit memory aliasing in for loop. (gosec)
Raw output
ledger/store/trackerdb/sqlitedriver/schema.go:790:55: G601: Implicit memory aliasing in for loop. (gosec)
deleteHash := trackerdb.AccountHashBuilderV6(addr, &state.old, state.oldEnc)
^
Check failure on line 799 in ledger/store/trackerdb/sqlitedriver/schema.go
github-actions / Lint Warnings
[Lint Warnings] ledger/store/trackerdb/sqlitedriver/schema.go#L799
G601: Implicit memory aliasing in for loop. (gosec)
Raw output
ledger/store/trackerdb/sqlitedriver/schema.go:799:52: G601: Implicit memory aliasing in for loop. (gosec)
addHash := trackerdb.AccountHashBuilderV6(addr, &state.new, state.newEnc)
^
Check failure on line 134 in ledger/acctdeltas.go
github-actions / Lint Warnings
[Lint Warnings] ledger/acctdeltas.go#L134
G601: Implicit memory aliasing in for loop. (gosec)
Raw output
ledger/acctdeltas.go:134:83: G601: Implicit memory aliasing in for loop. (gosec)
normalizedAccountBalances[i].EncodedResources[resource.aidx] = protocol.Encode(&resource.ResourcesData)
^
Check failure on line 136 in ledger/store/trackerdb/generickv/schema.go
github-actions / Lint Warnings
[Lint Warnings] ledger/store/trackerdb/generickv/schema.go#L136
func `creatableMaxRangePrefix` is unused (unused)
Raw output
ledger/store/trackerdb/generickv/schema.go:136:6: func `creatableMaxRangePrefix` is unused (unused)
func creatableMaxRangePrefix(maxIdx basics.CreatableIndex) ([3]byte, [11]byte) {
^
Check failure on line 38 in ledger/store/trackerdb/sqlitedriver/spVerificationAccessor.go
github-actions / Lint Warnings
[Lint Warnings] ledger/store/trackerdb/sqlitedriver/spVerificationAccessor.go#L38
type `stateProofVerificationReaderWriter` is unused (unused)
Raw output
ledger/store/trackerdb/sqlitedriver/spVerificationAccessor.go:38:6: type `stateProofVerificationReaderWriter` is unused (unused)
type stateProofVerificationReaderWriter struct {
^
Check failure on line 51 in ledger/store/trackerdb/sqlitedriver/spVerificationAccessor.go
github-actions / Lint Warnings
[Lint Warnings] ledger/store/trackerdb/sqlitedriver/spVerificationAccessor.go#L51
func `makeStateProofVerificationReaderWriter` is unused (unused)
Raw output
ledger/store/trackerdb/sqlitedriver/spVerificationAccessor.go:51:6: func `makeStateProofVerificationReaderWriter` is unused (unused)
func makeStateProofVerificationReaderWriter(q db.Queryable, e db.Executable) *stateProofVerificationReaderWriter {
^
Check failure on line 84 in data/transactions/verify/txn.go
github-actions / Lint Warnings
[Lint Warnings] data/transactions/verify/txn.go#L84
var `errTxGroupInsuffientLsigBudget` is unused (unused)
Raw output
data/transactions/verify/txn.go:84:5: var `errTxGroupInsuffientLsigBudget` is unused (unused)
var errTxGroupInsuffientLsigBudget = errors.New("txgroup lsig expectations exceed available budget")
^
Check failure on line 158 in tools/debug/transplanter/main.go
github-actions / Lint Warnings
[Lint Warnings] tools/debug/transplanter/main.go#L158
type `headerDecoder` is unused (unused)
Raw output
tools/debug/transplanter/main.go:158:6: type `headerDecoder` is unused (unused)
type headerDecoder interface {
^
Check failure on line 162 in tools/debug/transplanter/main.go
github-actions / Lint Warnings
[Lint Warnings] tools/debug/transplanter/main.go#L162
type `decoderV1` is unused (unused)
Raw output
tools/debug/transplanter/main.go:162:6: type `decoderV1` is unused (unused)
type decoderV1 struct{}
^
Check failure on line 164 in tools/debug/transplanter/main.go
github-actions / Lint Warnings
[Lint Warnings] tools/debug/transplanter/main.go#L164
func `decoderV1.decodeHeader` is unused (unused)
Raw output
tools/debug/transplanter/main.go:164:18: func `decoderV1.decodeHeader` is unused (unused)
func (decoderV1) decodeHeader(r *snappy.Reader) (*headerRow, int, error) {
^