Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with getValue() failing when in sourceview #298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leonardteo
Copy link

This fixes the bug where editor.getValue() fails when the editor is in source view (contenteditable mode).

@pulges
Copy link
Contributor

pulges commented Mar 4, 2016

It fixes the outcome of the error , but not the error itself.

From my point of view the toolbar component directly assigning editor.currentView object to string ("source") is not expected or valid thing to do for starters.

It would be better if editor.currentView should actually be pointed to the wysihtml5.views.Textarea as the view in return should have a getValue method (textarea has). (like it is done here: https://github.com/Voog/wysihtml/blob/master/src/editor.js#L111) Otherwise opening the html view allows bypassing the parser rules (user can save not allowed html to server and upon reloading editor later it starts clearing code unexpectedly too)

It requires rebuilding the toolbar component though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants