Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collected fixes (#509, #575) #589

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

clausreinke
Copy link

related PR: #586

Note: if you prefer your fixes separated, you can just pick the first commit from this branch for #509 and pull from branch fix_system_calls_on_windows for #575.

Claus Reinke added 5 commits March 31, 2015 20:26
- rename s:check_bundle_name to s:register_bundle_name,
  it has the side-effect of updating the bundle name registry
- expand possible return values
- re-registering a plugin name for the same bundle is no conflict
- don't continue processing plugins if registration fails
- ensure that all system calls go via installer.vim
  (vundle#installer#system, used to be s:system)
- escape/wrap complex command sequences
- log commands before trying to execute them
@clausreinke
Copy link
Author

Note discussion/testing in #575, especially the relevant vim patches referred to in https://github.com/airblade/vim-system-escape.
TODO: for vundle#installer#system, distinguish cmd.exe, not just windows?

- only test for os, vim version and patch level once
- on old vims, only wrap system argument for cmd.exe
@ismail
Copy link

ismail commented Jul 20, 2015

Any chance of merging this soon?

@ryanoasis
Copy link
Member

I think most fixes are going to be waiting until #619 (at least some first basic tests)

@ismail
Copy link

ismail commented Jul 20, 2015

Thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants