Adding another Vundle Log filetype + settings/highlighting #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At a brief cursory glance this looks harmless. Has anyone else tested this out? I will try to take a look today... |
|
@ryanoasis, thanks! I was using this build for a while, and I saw no issues. It's been a while since I've used this though, so there may be ways to improve the regexes and such. I haven't tested this with wget, curl, etc - only git. |
|
@nfischer I didn't get a chance yet but this is on my radar (for whatever that's worth 😉) |
|
👍 SGTM |
ryanoasis
added a commit
that referenced
this pull request
Apr 22, 2016
Adding another Vundle Log filetype + settings/highlighting
|
Finally got around to getting these into branch/release 0.10.3 Have only cursory tested Side note, not sure when it happened (seems to even happen on master) but during my testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds syntax highlighting to log files generated by the
:VundleLogcommand. This complements the syntax highlighting for the changelog, added in #633.This PR does 2 things:
My initial motivation for the highlighting was to emphasize errors, since these can be easily overlooked. This has some other useful highlighting, such as emphasizing plugin names and git changes, overall helping with readability.
Since this deals with
:VundleLogand the previous change deals with:VundleChangeLog, I decided to rename the previous file type from "vundlelog" to "vundlechangelog" and named my tile type to "vundlelog". Syntax files have been renamed accordingly, so the end behavior is the same. This would break anyvundlelogfile type specific configurations users have set up since #633 was merged, but aside from that, this should be mostly harmless. If this is a concern, I'm open to naming suggestions.