-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added variables for git, curl & wget executables. #684
base: master
Are you sure you want to change the base?
Conversation
… use Vundle with gVimPortable and PortableGit.
This seems useful and fairly safe but still needs testing. Can you give some more background information? What was the problem using vundle with gVimPortable? |
Vundle uses plain git, curl and wget commands and therefore these have to be in the search path. When using ProtableGit this is clearly not the case. let g:vundle#git_executable = expand($VIM.'\..\..\..\PortableGit\bin\git.exe')
let g:vundle#curl_executable = expand($VIM.'\..\..\..\PortableGit\mingw32\bin\curl.exe') |
Should be fairly straightforward as this PR factorizes the calls to the git executables. |
@layus Yeah you are correct it should be but once I saw the conflict I just stopped 😊 because I was just trying to get it all on the same branch quickly. I just need to look at it again, I don't think I need help but of course if I do I will let you know! Thanks 👍 |
Added variables for git, curl & wget executables
Harden system calls to git Fixes from PR #684 (cameris/master) re-applied to new function 's:make_git_command' Conflicts: autoload/vundle/installer.vim autoload/vundle/scripts.vim
Finally got around to getting these into branch/release 0.10.3 Have only cursory tested Side note, not sure when it happened (seems to even happen on master) but during my testing |
This makes it easies to use Vundle with gVimPortable (PortableApps.com) and PortableGit.