Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added variables for git, curl & wget executables. #684

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cameris
Copy link

@cameris cameris commented Jan 2, 2016

This makes it easies to use Vundle with gVimPortable (PortableApps.com) and PortableGit.

@ryanoasis
Copy link
Member

This seems useful and fairly safe but still needs testing.

Can you give some more background information? What was the problem using vundle with gVimPortable?

@cameris
Copy link
Author

cameris commented Feb 27, 2016

Vundle uses plain git, curl and wget commands and therefore these have to be in the search path. When using ProtableGit this is clearly not the case.
Hence with this patch applied, I have the following in my vimrc.

let g:vundle#git_executable = expand($VIM.'\..\..\..\PortableGit\bin\git.exe')
let g:vundle#curl_executable = expand($VIM.'\..\..\..\PortableGit\mingw32\bin\curl.exe')

@ryanoasis ryanoasis modified the milestone: 0.10.3 Mar 16, 2016
@ryanoasis
Copy link
Member

Just an update, I finally got around to merging these into a release branch but I need to resolve some conflicts regard #699 and #684 😄

@layus
Copy link

layus commented Apr 14, 2016

Should be fairly straightforward as this PR factorizes the calls to the git executables.
Do you need some help to merge this ?

@ryanoasis
Copy link
Member

@layus Yeah you are correct it should be but once I saw the conflict I just stopped 😊 because I was just trying to get it all on the same branch quickly.

I just need to look at it again, I don't think I need help but of course if I do I will let you know! Thanks 👍

ryanoasis added a commit that referenced this pull request Apr 22, 2016
Added variables for git, curl & wget executables
ryanoasis added a commit that referenced this pull request Apr 22, 2016
Harden system calls to git

Fixes from PR #684 (cameris/master) re-applied to new function 's:make_git_command'

Conflicts:
	autoload/vundle/installer.vim
	autoload/vundle/scripts.vim
@ryanoasis
Copy link
Member

Finally got around to getting these into branch/release 0.10.3

Have only cursory tested :VundleInstall, :VundleUpdate, :VundleSearch, and viewed the vundle log.

Side note, not sure when it happened (seems to even happen on master) but during my testing :VundleUpdate is VERY SLOW... maybe it is just on my end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants