Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to git commands hardening. #720

Open
wants to merge 2 commits into
base: 0.10.3
Choose a base branch
from

Conversation

layus
Copy link

@layus layus commented Apr 26, 2016

I tested the current release, and it breaks at update time and for changelog generation.

The issue is that you need to be in the git_dir for git to work correctly for submodules, but that you cannot move to the worktree when cloning (because it does not exist yet).

The changelog was broken because make_git_command was not available in that script.
I moved one function around and exported it.

I have now tested my changes within and outside vcsh (GIT_DIR set) for the following operations:

  • init (clone)
  • update
  • plugin removal
  • changelog
  • log (error reporting)

My apologizes for not having properly tested my previous patches.

... to get make_git_command in reach,
and keep that command in the scope of installer.vim
@ryanoasis
Copy link
Member

Thanks, I just haven't gotten around to it yet. Apologies.

@layus
Copy link
Author

layus commented May 17, 2016

No problem :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants