Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset GIT_DIR to unmess git calls. Fix #807. #808

Open
wants to merge 36 commits into
base: next
Choose a base branch
from

Commits on Apr 12, 2017

  1. Unset GIT_DIR to unmess git calls. Fix VundleVim#807.

    Vundle manipulates plugin folders by `cd`-ing into them and calling git
    via `call system(cmd)`. This doesn't work if GIT_DIR is set as a global
    environmental variable (most commonly by a git hook). Since there is no
    use case in which Vundle should respect GIT_DIR, this PR preemptively
    precedes all git calls with `unset GIT_DIR; `. This makes the git calls
    behave as expected without unsetting GIT_DIR in the environment beyond
    vim.
    shippy committed Apr 12, 2017
    Configuration menu
    Copy the full SHA
    1382847 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2017

  1. Clarify Readme.

    - closes VundleVim#281
    gmarik authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    3b55a85 View commit details
    Browse the repository at this point in the history
  2. Update minirc to Plugin namespace

    sukima authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    6cb5fb7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fdc63af View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d822e7b View commit details
    Browse the repository at this point in the history
  5. Allow updating specific plugins.

    Shahaf Arad authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    ec679e4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3cf90c5 View commit details
    Browse the repository at this point in the history
  7. Allow multiple calls to VundleChangelog.

    The command `silent pedit ...` was causing trouble if the user had `set
    hidden`.  Now we `bdelete` the changelog buffer before editing it anew.
    lucc authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    04828fa View commit details
    Browse the repository at this point in the history
  8. Remove unneeded variable setting.

    The variable is script local to autoload/vundle/scripts.vim since VundleVim#468.
    lucc authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    41ae35b View commit details
    Browse the repository at this point in the history
  9. Refactor global variables into script local variables.

    These variables only occur in one file each.  By making them script local
    variables this is "documented" in the code.  At the same time the global
    namespace is polluted less.
    
    Changed:
        g:bundle_names          -> s:bundle_names
        g:vundle_last_status    -> s:last_status
        g:vundle_log_file       -> s:log_file
        g:vundle_view           -> s:view
    lucc authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    9543d63 View commit details
    Browse the repository at this point in the history
  10. Allow multiple calls to VundleLog.

    If it was loaded, unload the log buffer before editing it.  Otherwise the
    editing command can "hang" if the user has `set hidden`.
    
    This problem was originally discovered with the VundleChangelog command and
    the analogous fix was applied in 7d9b10.  See github issue VundleVim#468 for more.
    lucc authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    c56827d View commit details
    Browse the repository at this point in the history
  11. Refactor global variables into autoload variables.

    All global variables that are not part of the public API (mentioned in the
    documentation) are turned into autoload variables.  This is intended to give
    all global variables defined by Vundle.vim a common prefix.  The variable
    g:default_git_proto is part of the public API and is therefor not changed.
    This is the only exception.
    
    Changed:
       g:bundle_dir            -> vundle#bundle_dir
       g:bundles               -> vundle#bundles
       g:updated_bundles       -> vundle#updated_bundles
       g:vundle_lazy_load      -> vundle#lazy_load
       g:vundle_log            -> vundle#log
    Unchanged:
       g:default_git_proto
    lucc authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    ed96672 View commit details
    Browse the repository at this point in the history
  12. Set default values for autoload variables.

    The setting of the default values for the autoload variables is moved out of
    any function.  One reason being that these settings do not depend on the
    argument of the function.  The second being that Vim will source the autoload
    script if an undefined autoload variable is referenced and the file is
    expected to define the variable (see :help autoload).
    lucc authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    d75d5a3 View commit details
    Browse the repository at this point in the history
  13. Prevent insecure plugin names.

    Plugins' names which contain '../', '$HOME', '%:h:h', '..\', etc.
    can be dangerous.
    Use a sensible whitelist for plugin names and prevent its expansion.
    Shahaf Arad authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    66d501b View commit details
    Browse the repository at this point in the history
  14. Update repository references.

    Saves a 301 redirect and removes a tad bit of confusion when `git
    clone`-ing Vundle when installing.
    dleve123 authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    5865ea7 View commit details
    Browse the repository at this point in the history
  15. Vundle log, changelog, and scripts-view are no longer modifiable and the

    buffers will not persist after they're closed.
    nfischer authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    d115e04 View commit details
    Browse the repository at this point in the history
  16. Update repository references throughout documentation. Also, fixed an

    incorrect URL and updated references to ':Bundle' commands to ':Plugin'
    commands
    nfischer authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    d2cef2c View commit details
    Browse the repository at this point in the history
  17. Add 'vundlelog' filetype + settings/highlighting

    Chip Hogg authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    2803c64 View commit details
    Browse the repository at this point in the history
  18. readme_zh_ch

    wsdjeg authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    29572e7 View commit details
    Browse the repository at this point in the history
  19. readme_zh_ch

    wsdjeg authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    87bfb7f View commit details
    Browse the repository at this point in the history
  20. finished readme

    wsdjeg authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    309995c View commit details
    Browse the repository at this point in the history
  21. Setting Vundle key mappings to be silent.

    nfischer authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    68bd818 View commit details
    Browse the repository at this point in the history
  22. Update example in readme

    wsdjeg authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    49ae71c View commit details
    Browse the repository at this point in the history
  23. A traditional Chinese version of the README

    This is done based on the simplified Chinese version at commit 232cb92.
    Traditional Chinese is used by people in Taiwan, Hong Kong and Macao.
    VincentTam authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    f38d282 View commit details
    Browse the repository at this point in the history
  24. Corrected a missing word

    VincentTam authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    8ab491c View commit details
    Browse the repository at this point in the history
  25. Removed BOM and CR

    They are added by Notepad on M$ Windows.
    VincentTam authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    7257890 View commit details
    Browse the repository at this point in the history
  26. A change corresponding to 52f3443

    A traditional Chinese version of the updated `README_ZH_CN.md`.
    VincentTam authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    aa7b500 View commit details
    Browse the repository at this point in the history
  27. Update README_ZH_CN.md

    Fix typo
    archersmind authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    c3da227 View commit details
    Browse the repository at this point in the history
  28. A change corresponding to f4cea90

    A traditional Chinese version of the updated `README_ZH_CN.md`.
    VincentTam authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    b97af5a View commit details
    Browse the repository at this point in the history
  29. Use github markdown checkmarks (VundleVim#749)

    * Updates readme to use github markdown checkmarks
    calebeby authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    469cee1 View commit details
    Browse the repository at this point in the history
  30. refine Chinese (Traditional) translations

    vfreex authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    e42efc2 View commit details
    Browse the repository at this point in the history
  31. Remove example script which breaks install

    According to this discussion VundleVim#713 this plugin is simply an example, but the example seems to consistently break the installation process.
    
    If this is the case better to remove it.
    
    Another example of it causing problems: VundleVim#784
    kirkins authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    a2f63d7 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    af198a4 View commit details
    Browse the repository at this point in the history
  33. Comment instead of removing L9 plugin

    kirkins authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    8f089ec View commit details
    Browse the repository at this point in the history
  34. Comment other reference to L9

    kirkins authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    cc36ca5 View commit details
    Browse the repository at this point in the history
  35. accidentally a 'set' in my vimrc

    shell=/bin/bash needs to start with `set` in order to actually make vim+fish work correctly.
    gregorycerna authored and shippy committed Apr 13, 2017
    Configuration menu
    Copy the full SHA
    8b71a61 View commit details
    Browse the repository at this point in the history